From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756008Ab1FTXWs (ORCPT ); Mon, 20 Jun 2011 19:22:48 -0400 Received: from smtp-out.google.com ([74.125.121.67]:22586 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755170Ab1FTXWr (ORCPT ); Mon, 20 Jun 2011 19:22:47 -0400 From: Mandeep Singh Baines To: linux-kernel@vger.kernel.org Cc: Hugh Dickins , Mandeep Singh Baines , Andrew Morton , Huang Ying , Andi Kleen , Olaf Hering Subject: [PATCH 1/2] panic: panic=-1 for immediate reboot Date: Mon, 20 Jun 2011 16:22:08 -0700 Message-Id: <1308612129-12488-1-git-send-email-msb@chromium.org> X-Mailer: git-send-email 1.7.3.1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hugh Dickins When kernel BUG or oops occurs, ChromeOS intends to panic and immediately reboot, with stacktrace and other messages preserved in RAM across reboot. But the longer we delay, the more likely the user is to poweroff and lose the info. panic_timeout (seconds before rebooting) is set by panic= boot option or sysctl or /proc/sys/kernel/panic; but 0 means wait forever, so at present we have to delay at least 1 second. Let a negative number mean reboot immediately (with the small cosmetic benefit of suppressing that newline-less "Rebooting in %d seconds.." message). Signed-off-by: Hugh Dickins Signed-off-by: Mandeep Singh Baines Cc: Andrew Morton Cc: Huang Ying Cc: Andi Kleen Cc: Hugh Dickins Cc: Olaf Hering --- kernel/panic.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/panic.c b/kernel/panic.c index 6923167..d7bb697 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -119,6 +119,8 @@ NORET_TYPE void panic(const char * fmt, ...) } mdelay(PANIC_TIMER_STEP); } + } + if (panic_timeout != 0) { /* * This will not be a clean reboot, with everything * shutting down. But if there is a chance of -- 1.7.3.1