From: Steven Rostedt <rostedt@goodmis.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 03/11] blackfin/irqs: Do not trace arch_local_{*,irq_*} functions
Date: Sat, 02 Jul 2011 12:11:22 -0400 [thread overview]
Message-ID: <1309623082.26417.163.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <CAMjpGUfHw-CO=ydCew5FqG0RLQOMk8+NpVjvBdV4Nv-tiDavqg@mail.gmail.com>
On Sat, 2011-07-02 at 02:50 -0400, Mike Frysinger wrote:
> On Fri, Jul 1, 2011 at 23:04, Steven Rostedt wrote:
> > Do not trace arch_local_save_flags(), arch_local_irq_*() and friends.
> > Although they are marked inline, gcc may still make a function out of
> > them and add it to the pool of functions that are traced by the function
> > tracer. This can cause undesirable results (kernel panic, triple faults,
> > etc).
> >
> > Add the notrace notation to prevent them from ever being traced.
>
> what about putting the markings in include/asm-generic/irqflags.h ?
> then you wouldnt have to update every arch (or at least, not as much).
One of my patches do that, but it only helps superH, as that's the only
arch that uses that header and implements function tracing.
-- Steve
next prev parent reply other threads:[~2011-07-02 16:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110702030435.308336775@goodmis.org>
2011-07-02 3:04 ` [patch 01/11] x86/irqs: Do not trace arch_local_{*,irq_*} functions Steven Rostedt
2011-07-07 0:51 ` Steven Rostedt
2011-07-07 21:43 ` [tip:perf/core] tracing, x86/irq: Do not trace arch_local_{*,irq_*}() functions tip-bot for Steven Rostedt
2011-07-02 3:04 ` [patch 02/11] arm/irqs: Do not trace arch_local_{*,irq_*} functions Steven Rostedt
2011-07-02 3:04 ` [patch 03/11] blackfin/irqs: " Steven Rostedt
2011-07-02 6:50 ` Mike Frysinger
2011-07-02 16:11 ` Steven Rostedt [this message]
2011-07-02 16:39 ` Mike Frysinger
2011-07-02 16:40 ` Mike Frysinger
2011-07-05 12:51 ` Steven Rostedt
2011-07-05 16:20 ` Mike Frysinger
2011-07-05 19:07 ` Mike Frysinger
2011-07-05 19:13 ` Steven Rostedt
2011-07-05 19:25 ` Mike Frysinger
2011-07-02 3:04 ` [patch 04/11] ia64/irqs: " Steven Rostedt
2011-07-02 3:04 ` [patch 05/11] microblaze/irqs: " Steven Rostedt
2011-07-05 10:43 ` Michal Simek
2011-07-05 12:49 ` Steven Rostedt
2011-07-02 3:04 ` [patch 06/11] mips/irqs: " Steven Rostedt
2011-07-02 3:04 ` [patch 07/11] parisc/irqs: " Steven Rostedt
2011-07-02 3:04 ` [patch 08/11] powerpc/irqs: " Steven Rostedt
2011-07-02 3:04 ` [patch 09/11] s390/irqs: " Steven Rostedt
2011-07-04 8:10 ` Martin Schwidefsky
2011-07-05 12:49 ` Steven Rostedt
2011-07-02 3:04 ` [patch 10/11] sh/unicore32/irqs: " Steven Rostedt
2011-07-04 1:56 ` Guan Xuetao
2011-07-05 12:50 ` Steven Rostedt
2011-07-11 3:34 ` Paul Mundt
2011-07-13 1:36 ` Steven Rostedt
2011-07-02 3:04 ` [patch 11/11] sparc/irqs: " Steven Rostedt
2011-07-02 4:11 ` David Miller
2011-07-05 12:49 ` Steven Rostedt
2011-07-06 6:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309623082.26417.163.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).