From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932415AbcH1HSx (ORCPT <rfc822;w@1wt.eu>);
        Sun, 28 Aug 2016 03:18:53 -0400
Received: from mout.web.de ([212.227.15.3]:56690 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932332AbcH1HSv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 28 Aug 2016 03:18:51 -0400
Subject: Re: [PATCH 8/8] cris-cryptocop: Apply another recommendation from
 "checkpatch.pl"
To: Julia Lawall <julia.lawall@lip6.fr>
References: <566ABCD9.1060404@users.sourceforge.net>
 <bfc23090-e05d-f491-2a28-1803ceb31a31@users.sourceforge.net>
 <0e29d372-ef5f-afa7-50b1-70ddc089ef00@users.sourceforge.net>
 <alpine.DEB.2.10.1608272105110.3363@hadrien>
Cc: linux-cris-kernel@axis.com,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        Jiri Kosina <jkosina@suse.cz>, Mikael Starvik <starvik@axis.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <130cda68-feed-8b48-e928-7e915888c7c9@users.sourceforge.net>
Date: Sun, 28 Aug 2016 09:18:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1608272105110.3363@hadrien>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:KIDd7p44dQWVnbcVKcjLmsGme99EBH+uxSxyxnnB7vRZeMErIco
 6ikB34q7r04XQdHyVVc4fXT/mgvHj3RfCzoMNqSB3T1sAzFaVN0h5aNVduJr7sV7mIjaSCC
 KSV5uj4S9CrkvDH9DEyk2sMPuMaHZMpnjYTlNP565t7lu399kYhhwVKQlkESe8HEKgrz+pr
 7y3CCrJeM88LPVTEdK0cA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:4WjaigDUjLc=:E4K1L4EjCrfgONeDJD5WYV
 hjQowOLc7172zYBApQM4OCLWZ2MDaDgT8QRL6D2iKHl6qPi+rbQhDpP9pyrQN/20mdFIqL4y0
 y98vs33UO917fsXVIhktF+L8J0JISc42WXgWeQRyYnqcNubKpJMZGphzKE9EBVMuo4NTb+hPh
 Vq5MGDPQKKHnBURLGcDXRkBd6kQ9xmsr62ceb6DAjLTNxicZo5uyS18EAjLcWRjCehtVaG2MV
 BC/erxOOWeAODht64gWk+HqXJpJGJ853pdZh1exH8vHaVKtuNrKusjZ5U82umjHaK+lRvnRAf
 kgcBRlv0u33O/WtNHHwGpKqk9qH2SDeuqyg2iC+MaU3LyhEZxXVBH96iFvlQuqgCKhvFqPmUI
 z750MZlXoNnHf/9q58C4goJHEyHT9QXyRxvfQn1X3H4I90hdN9A8IA93M9Edj10XLQUTjCHi6
 8NLxuk4WQ+6zFd+TYCSWRDgxXHy5Kdbi8mTjXEgi+UxYMSvJNWg6SHKexrp3uI411KkDr+prM
 9IWSl4aJQKU9z+hEa7uy3blLQZTsh9YnLVAjf4yEe985IGNZMGCWrVibGh0wHymycP5GcPQAL
 Oe/ousKPRtjnpOvarO3NtJHv/zOXgZ2cAwbpxoID5Ky560wkG+mc2ZZSrWtbo2+290o5TyF0x
 UnX1KMzwwJgDoEeKkNcI6MKPDZ5+WaaMX3yKV+D0I5gzgwsXLBYgnVhjSOzP8rJgniAoodkoY
 Mra4TeLd+YXmbmCGltKYJjMRu8xC728yA7oOqu7wP+aPIPgS85LjSEh7BOVnAaeDHf1lZWxUX
 cPsWGkl
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -2276,7 +2277,10 @@ static int cryptocop_job_setup(struct cryptocop_prio_job **pj, struct cryptocop_
>>  		(*pj)->iop->ctx_in.saved_data = operation->list_op.inlist;
>>  		(*pj)->iop->ctx_in.saved_data_buf = operation->list_op.in_data_buf;
>>  	} else {
>> -		if ((err = cryptocop_setup_dma_list(operation, &(*pj)->iop, alloc_flag))) {
>> +		err = cryptocop_setup_dma_list(operation,
>> +					       &(*pj)->iop,
>> +					       alloc_flag);
> 
> Checkpatch didn't say to put every argument on a different line,

I agree to this information.


> and that wasn't done before, so why do it now?

I tend to give each function parameter its own text line in such an use case
(for the known length limitation).


> There is plenty of room for at least &(*pj)->iop on the line before.

This is true. - Do you prefer an other indentation approach here?

Regards,
Markus