* [PATCH] drm: add missing header file <linuc/types.h>
@ 2011-08-08 7:22 Amerigo Wang
2011-08-09 13:32 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Amerigo Wang @ 2011-08-08 7:22 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, WANG Cong, David Airlie, Keith Packard, dri-devel
This patch fixes the following 'make headers_check' errors:
linux-2.6/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h>
linux-2.6/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h>
linux-2.6/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h>
linux-2.6/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h>
linux-2.6/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
Signed-off-by: WANG Cong <amwang@redhat.com>
---
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
index c4961ea..fe8005f 100644
--- a/include/drm/drm_mode.h
+++ b/include/drm/drm_mode.h
@@ -81,6 +81,8 @@
#define DRM_MODE_DIRTY_ON 1
#define DRM_MODE_DIRTY_ANNOTATE 2
+#include <linux/types.h>
+
struct drm_mode_modeinfo {
__u32 clock;
__u16 hdisplay, hsync_start, hsync_end, htotal, hskew;
diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
index 28c0d11..d7ddd33 100644
--- a/include/drm/i915_drm.h
+++ b/include/drm/i915_drm.h
@@ -27,6 +27,7 @@
#ifndef _I915_DRM_H_
#define _I915_DRM_H_
+#include <linux/types.h>
#include "drm.h"
/* Please note that modifications to all structs defined here are
diff --git a/include/drm/mga_drm.h b/include/drm/mga_drm.h
index fca8170..8058ce0 100644
--- a/include/drm/mga_drm.h
+++ b/include/drm/mga_drm.h
@@ -35,6 +35,7 @@
#ifndef __MGA_DRM_H__
#define __MGA_DRM_H__
+#include <linux/types.h>
#include "drm.h"
/* WARNING: If you change any of these defines, make sure to change the
diff --git a/include/drm/radeon_drm.h b/include/drm/radeon_drm.h
index b65be60..f0be4c7 100644
--- a/include/drm/radeon_drm.h
+++ b/include/drm/radeon_drm.h
@@ -33,6 +33,7 @@
#ifndef __RADEON_DRM_H__
#define __RADEON_DRM_H__
+#include <linux/types.h>
#include "drm.h"
/* WARNING: If you change any of these defines, make sure to change the
diff --git a/include/drm/via_drm.h b/include/drm/via_drm.h
index fd11a5b..23880b0 100644
--- a/include/drm/via_drm.h
+++ b/include/drm/via_drm.h
@@ -24,6 +24,7 @@
#ifndef _VIA_DRM_H_
#define _VIA_DRM_H_
+#include <linux/types.h>
#include "drm.h"
/* WARNING: These defines must be the same as what the Xserver uses.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: add missing header file <linuc/types.h>
2011-08-08 7:22 [PATCH] drm: add missing header file <linuc/types.h> Amerigo Wang
@ 2011-08-09 13:32 ` Alex Deucher
2011-08-10 3:31 ` Cong Wang
0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2011-08-09 13:32 UTC (permalink / raw)
To: Amerigo Wang; +Cc: linux-kernel, akpm, dri-devel
On Mon, Aug 8, 2011 at 3:22 AM, Amerigo Wang <amwang@redhat.com> wrote:
> This patch fixes the following 'make headers_check' errors:
>
> linux-2.6/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-2.6/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-2.6/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-2.6/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux-2.6/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
>
These files are shared with BSD, and they get the linux/types.h from drm.h.
Alex
> Signed-off-by: WANG Cong <amwang@redhat.com>
>
> ---
> diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
> index c4961ea..fe8005f 100644
> --- a/include/drm/drm_mode.h
> +++ b/include/drm/drm_mode.h
> @@ -81,6 +81,8 @@
> #define DRM_MODE_DIRTY_ON 1
> #define DRM_MODE_DIRTY_ANNOTATE 2
>
> +#include <linux/types.h>
> +
> struct drm_mode_modeinfo {
> __u32 clock;
> __u16 hdisplay, hsync_start, hsync_end, htotal, hskew;
> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
> index 28c0d11..d7ddd33 100644
> --- a/include/drm/i915_drm.h
> +++ b/include/drm/i915_drm.h
> @@ -27,6 +27,7 @@
> #ifndef _I915_DRM_H_
> #define _I915_DRM_H_
>
> +#include <linux/types.h>
> #include "drm.h"
>
> /* Please note that modifications to all structs defined here are
> diff --git a/include/drm/mga_drm.h b/include/drm/mga_drm.h
> index fca8170..8058ce0 100644
> --- a/include/drm/mga_drm.h
> +++ b/include/drm/mga_drm.h
> @@ -35,6 +35,7 @@
> #ifndef __MGA_DRM_H__
> #define __MGA_DRM_H__
>
> +#include <linux/types.h>
> #include "drm.h"
>
> /* WARNING: If you change any of these defines, make sure to change the
> diff --git a/include/drm/radeon_drm.h b/include/drm/radeon_drm.h
> index b65be60..f0be4c7 100644
> --- a/include/drm/radeon_drm.h
> +++ b/include/drm/radeon_drm.h
> @@ -33,6 +33,7 @@
> #ifndef __RADEON_DRM_H__
> #define __RADEON_DRM_H__
>
> +#include <linux/types.h>
> #include "drm.h"
>
> /* WARNING: If you change any of these defines, make sure to change the
> diff --git a/include/drm/via_drm.h b/include/drm/via_drm.h
> index fd11a5b..23880b0 100644
> --- a/include/drm/via_drm.h
> +++ b/include/drm/via_drm.h
> @@ -24,6 +24,7 @@
> #ifndef _VIA_DRM_H_
> #define _VIA_DRM_H_
>
> +#include <linux/types.h>
> #include "drm.h"
>
> /* WARNING: These defines must be the same as what the Xserver uses.
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: add missing header file <linuc/types.h>
2011-08-09 13:32 ` Alex Deucher
@ 2011-08-10 3:31 ` Cong Wang
0 siblings, 0 replies; 3+ messages in thread
From: Cong Wang @ 2011-08-10 3:31 UTC (permalink / raw)
To: Alex Deucher; +Cc: linux-kernel, akpm, dri-devel
于 2011年08月09日 21:32, Alex Deucher 写道:
> On Mon, Aug 8, 2011 at 3:22 AM, Amerigo Wang<amwang@redhat.com> wrote:
>> This patch fixes the following 'make headers_check' errors:
>>
>> linux-2.6/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include<linux/types.h>
>> linux-2.6/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include<linux/types.h>
>> linux-2.6/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include<linux/types.h>
>> linux-2.6/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include<linux/types.h>
>> linux-2.6/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include<linux/types.h>
>>
>
> These files are shared with BSD, and they get the linux/types.h from drm.h.
>
Thanks, then these warnings should be bogus.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-10 3:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-08 7:22 [PATCH] drm: add missing header file <linuc/types.h> Amerigo Wang
2011-08-09 13:32 ` Alex Deucher
2011-08-10 3:31 ` Cong Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).