linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guan Xuetao <gxt@mprc.pku.edu.cn>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 03/11] arch/unicore32: do not use EXTRA_AFLAGS or EXTRA_CFLAGS
Date: Thu, 18 Aug 2011 16:00:57 +0800	[thread overview]
Message-ID: <1313654457.2905.10.camel@epip-laptop> (raw)
In-Reply-To: <CACqU3MWTEFy+XV7WH=FEP2hTvBu8VCgcYj-HCcVnSjKxZBQeeA@mail.gmail.com>

It looks good for me.

Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>

Do I need to push the patch into unicore32 repo?

Thanks & Regards

Guan Xuetao


On Mon, 2011-08-15 at 01:13 -0400, Arnaud Lacombe wrote:
> Hi,
> 
> On Mon, Aug 15, 2011 at 1:07 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> > Usage of these flags has been deprecated for nearly 4 years by:
> >
> >    commit f77bf01425b11947eeb3b5b54685212c302741b8
> >    Author: Sam Ravnborg <sam@neptun.(none)>
> >    Date:   Mon Oct 15 22:25:06 2007 +0200
> >
> >        kbuild: introduce ccflags-y, asflags-y and ldflags-y
> >
> > Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
> > line use. By default, gmake(1) do not override command line setting, so this is
> > likely to result in build failure or unexpected behavior.
> >
> > Replace their usage by Kbuild's `{as,cc,ld}flags-y'.
> >
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> 
>  - Arnaud
> > ---
> >  arch/unicore32/boot/compressed/Makefile |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/unicore32/boot/compressed/Makefile b/arch/unicore32/boot/compressed/Makefile
> > index b0954a2..950a9af 100644
> > --- a/arch/unicore32/boot/compressed/Makefile
> > +++ b/arch/unicore32/boot/compressed/Makefile
> > @@ -10,8 +10,8 @@
> >  # Copyright (C) 2001~2010 GUAN Xue-tao
> >  #
> >
> > -EXTRA_CFLAGS   := -fpic -fno-builtin
> > -EXTRA_AFLAGS   := -Wa,-march=all
> > +ccflags-y      := -fpic -fno-builtin
> > +asflags-y      := -Wa,-march=all
> >
> >  OBJS           := misc.o
> >
> > --
> > 1.7.6.153.g78432
> >
> >



  reply	other threads:[~2011-08-18  8:00 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-15  5:07 [PATCH 00/11] Fix in-tree usage of EXTRA_{A,C,CPP,LD}FLAGS Arnaud Lacombe
2011-08-15  5:07 ` [PATCH 01/11] arch/m68k: do not use EXTRA_{A,C,LD}FLAGS Arnaud Lacombe
2011-08-15  5:11   ` Arnaud Lacombe
2011-08-15  7:26   ` Finn Thain
2011-08-15 14:45     ` Arnaud Lacombe
2011-08-15  5:07 ` [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS Arnaud Lacombe
2011-08-15  9:45   ` Sergei Shtylyov
2011-08-15 13:55     ` Ralf Baechle
2011-08-15 16:19       ` Arnaud Lacombe
2011-08-15 17:28         ` Jayachandran C.
2011-08-16 10:05           ` Ralf Baechle
2011-08-15  5:07 ` [PATCH 03/11] arch/unicore32: do not use EXTRA_AFLAGS or EXTRA_CFLAGS Arnaud Lacombe
2011-08-15  5:13   ` Arnaud Lacombe
2011-08-18  8:00     ` Guan Xuetao [this message]
2011-08-18 16:37       ` Arnaud Lacombe
2011-08-19  6:54         ` Guan Xuetao
2011-08-15  5:07 ` [PATCH 04/11] arch/x86: do not use EXTRA_CFLAGS Arnaud Lacombe
2011-08-15  5:14   ` Arnaud Lacombe
2011-08-15  5:07 ` [PATCH 05/11] drivers/media: " Arnaud Lacombe
2011-08-15  5:15   ` Arnaud Lacombe
2011-08-16  8:15   ` Laurent Pinchart
2011-08-15  5:07 ` [PATCH 06/11] drivers/net/bna: " Arnaud Lacombe
2011-08-15  5:16   ` Arnaud Lacombe
2011-08-15  5:07 ` [PATCH 07/11] drivers/pps: " Arnaud Lacombe
2011-08-15  5:16   ` Arnaud Lacombe
2011-08-15  5:07 ` [PATCH 08/11] drivers/scsi: " Arnaud Lacombe
2011-08-15  5:16   ` Arnaud Lacombe
2011-08-15  5:07 ` [PATCH 09/11] drivers/staging: " Arnaud Lacombe
2011-08-15  5:15   ` Arnaud Lacombe
2011-08-15  5:07 ` [PATCH 10/11] scripts/Makefile.build: do not reference EXTRA_CFLAGS as CFLAGS replacement Arnaud Lacombe
2011-08-22 15:50   ` Arnaud Lacombe
2011-08-31 14:43   ` Michal Marek
2011-08-15  5:07 ` [PATCH 11/11] script/checkpatch.pl: warn about deprecated use of EXTRA_{A,C,CPP,LD}FLAGS Arnaud Lacombe
2011-08-15  5:10   ` Arnaud Lacombe
2011-08-31 14:44   ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313654457.2905.10.camel@epip-laptop \
    --to=gxt@mprc.pku.edu.cn \
    --cc=lacombar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).