From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752878Ab1HVU3u (ORCPT ); Mon, 22 Aug 2011 16:29:50 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:34951 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233Ab1HVU3r (ORCPT ); Mon, 22 Aug 2011 16:29:47 -0400 X-Authority-Analysis: v=1.1 cv=Pm0sEXe2MdIPK/rOEC7hwDW84D/yDsPO3JtCzsVYOFU= c=1 sm=0 a=W4pQ5Nb2e1IA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=1XWaLZrsAAAA:8 a=3uKURUYvAroH6azE7yEA:9 a=PUjeQqilurYA:10 a=UTB_XpHje0EA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 67.242.120.143 Subject: Re: [PATCH v2 3/5] trace: Add per_cpu ring buffer control files From: Steven Rostedt To: Vaibhav Nagarnaik Cc: Michael Rubin , David Sharp , linux-kernel@vger.kernel.org In-Reply-To: <1313531179-9323-4-git-send-email-vnagarnaik@google.com> References: <1311721194-12164-1-git-send-email-vnagarnaik@google.com> <1313531179-9323-4-git-send-email-vnagarnaik@google.com> Content-Type: text/plain; charset="ISO-8859-15" Date: Mon, 22 Aug 2011 16:29:41 -0400 Message-ID: <1314044981.15704.140.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-08-16 at 14:46 -0700, Vaibhav Nagarnaik wrote: > Add a debugfs entry under per_cpu/ folder for each cpu called > buffer_size_kb to control the ring buffer size for each CPU > independently. > > If the global file buffer_size_kb is used to set size, the individual > ring buffers will be adjusted to the given size. The buffer_size_kb will > report the common size to maintain backward compatibility. > > If the buffer_size_kb file under the per_cpu/ directory is used to > change buffer size for a specific CPU, only the size of the respective > ring buffer is updated. When tracing/buffer_size_kb is read, it reports > 'X' to indicate that sizes of per_cpu ring buffers are not equivalent. > > Signed-off-by: Vaibhav Nagarnaik This patch wasn't tested against any of the latency tracers being enabled or hot plug: /home/rostedt/work/autotest/nobackup/linux-test.git/kernel/trace/ring_buffer.c: In function 'ring_buffer_swap_cpu': /home/rostedt/work/autotest/nobackup/linux-test.git/kernel/trace/ring_buffer.c:3761:14: error: 'struct ring_buffer' has no member named 'pages' /home/rostedt/work/autotest/nobackup/linux-test.git/kernel/trace/ring_buffer.c:3761:33: error: 'struct ring_buffer' has no member named 'pages' CC kernel/trace/trace_syscalls.o /home/rostedt/work/autotest/nobackup/linux-test.git/kernel/trace/ring_buffer.c: In function 'rb_cpu_notify': /home/rostedt/work/autotest/nobackup/linux-test.git/kernel/trace/ring_buffer.c:4136:4: error: too few arguments to function 'rb_allocate_cpu_buffer' /home/rostedt/work/autotest/nobackup/linux-test.git/kernel/trace/ring_buffer.c:1066:1: note: declared here -- Steve