From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753826AbcKJHqp (ORCPT ); Thu, 10 Nov 2016 02:46:45 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:32062 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbcKJHqn (ORCPT ); Thu, 10 Nov 2016 02:46:43 -0500 X-AuditID: cbfec7f5-f79ce6d000004c54-14-582425dd2c4b Subject: Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver To: Rob Herring Cc: Andi Shyti , Mauro Carvalho Chehab , Sean Young , Mark Rutland , Richard Purdie , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org From: Jacek Anaszewski Message-id: <13210179-ea3f-6106-e3c0-fa30b83e23cc@samsung.com> Date: Thu, 10 Nov 2016 08:46:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <20161109182621.ttfxtdt32q3cqce7@rob-hp-laptop> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOKsWRmVeSWpSXmKPExsWy7djP87p3VVUiDM7u1bTYfuQZq8X8I+dY LS7vmsNmsfXNOkaLng1bWS2WXr/IZLH6WYXF/z072C1273rKarHw6XcWBy6PNfPWMHpsWtXJ 5rHkjbXHlv677B575v9g9ejbsorR4/MmuQD2KC6blNSczLLUIn27BK6M0582MhUc5KlYeHEj UwNjI1cXIyeHhICJRPeHo0wQtpjEhXvr2boYuTiEBJYySjRMvMwE4XxmlFjwupEFpuPli6Ws EIlljBLNa7axQzjPGCV2nD3MDFIlLJAocePsUVYQW0RAUeJ32zSwDmaBHUwSuz83s4Mk2AQM JX6+eA22nFfATmJl6yqg5RwcLAKqEj9fMoKYogIRErvvpkJUCEr8mHwP7AhOARuJz1NWg3Uy CzhKPFi0kxXClpfYvOYtM8Shp9glnq23BhkjISArsekAVNhF4s/EO6wQtrDEq+Nb2CFsGYnL k7tZQK6UEJjMKHHx2E1WCGc1o8TGzk6o760lGv7/YoFYxicxadt0ZogFvBIdbUIQpofEvFvC ENWOEs8fbGKGBM9EZolN/1+wTGCUn4XknVlIXpiF5IUFjMyrGEVSS4tz01OLTfWKE3OLS/PS 9ZLzczcxApPP6X/Hv+5gXHrM6hCjAAejEg9vh6ZyhBBrYllxZe4hRgkOZiUR3vcqKhFCvCmJ lVWpRfnxRaU5qcWHGKU5WJTEefcsuBIuJJCeWJKanZpakFoEk2Xi4JRqYHT9vdHSzr9mvmjt Q72e6SwRF1/GbX15fI6ewoY+cZVvr6Jm5fT4N/yKMzpWIbzwous3x4/5dc+WdnG77lq+22iV UGi3D8NPvqufZNcv6b3GM3k7g+QG09nd/WJhU2XlOZd6LGFee6MlfradasVc7QOPbv7I698l fKpH4G0wW/efxcs6oiaZKCixFGckGmoxFxUnAgAamHr0OgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t/xq7oHVFUiDN4slbLYfuQZq8X8I+dY LS7vmsNmsfXNOkaLng1bWS2WXr/IZLH6WYXF/z072C1273rKarHw6XcWBy6PNfPWMHpsWtXJ 5rHkjbXHlv677B575v9g9ejbsorR4/MmuQD2KDebjNTElNQihdS85PyUzLx0W6XQEDddCyWF vMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nbJbhlnP60kangIE/FwosbmRoYG7m6GDk5 JARMJF6+WMoKYYtJXLi3nq2LkYtDSGAJo8S2q/dYIJxnjBJXLnSBVQkLJErcOHsUzBYRUJT4 3TaNFaJoIrPE8gVvwRxmgR1MErOutLGDVLEJGEr8fPGaCcTmFbCTWNm6CmgHBweLgKrEz5eM IGFRgQiJW6s+MkKUCEr8mAyymZODU8BG4vOU1WCtzAK2Egver2OBsOUlNq95yzyBUWAWkpZZ SMpmISlbwMi8ilEktbQ4Nz232EivODG3uDQvXS85P3cTIzAatx37uWUHY9e74EOMAhyMSjy8 HZrKEUKsiWXFlbmHGCU4mJVEeN+rqEQI8aYkVlalFuXHF5XmpBYfYjQF+mEis5Rocj4wUeSV xBuaGJpbGhoZW1iYGxkpifNO/XAlXEggPbEkNTs1tSC1CKaPiYNTqoGR7euh8iVPTu7/dCdx m/o0q73zlE/4zn7V9Zn3VeN74Tru59ZxF+/tY727qmab3nrBWi6DsM8ST6x1OlLEvWXEGULe a4vf2vFz1f1DwWqrw6ZabdyS7hZ5Qnv29qkJckGT/x8oLDww891dhcjVXVeMjbdMdOR/ez/z xQzhwgevxVZEBa49u0DMT4mlOCPRUIu5qDgRAD2TvofcAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161110074637eucas1p2a32691f5f5918dc7a99cbcbaf48efa5e X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161102104149epcas5p4da68197e232df7ad922f2f9cb0714a43 X-RootMTR: 20161102104149epcas5p4da68197e232df7ad922f2f9cb0714a43 References: <20161102104010.26959-1-andi.shyti@samsung.com> <20161102104010.26959-6-andi.shyti@samsung.com> <70f4426b-e2e6-1fb7-187a-65ed4bce0668@samsung.com> <20161103101048.ofyoko4mkcypf44u@gangnam.samsung> <70e31ed5-e1ec-cac3-3c3d-02c75f1418bd@samsung.com> <20161109182621.ttfxtdt32q3cqce7@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2016 07:26 PM, Rob Herring wrote: > On Thu, Nov 03, 2016 at 11:39:21AM +0100, Jacek Anaszewski wrote: >> On 11/03/2016 11:10 AM, Andi Shyti wrote: >>> Hi Jacek, >>> >>>> Only DT bindings of LED class drivers should be placed in >>>> Documentation/devicetree/bindings/leds. Please move it to the >>>> media bindings. >>> >>> that's where I placed it first, but Rob asked me to put it in the >>> LED directory and Cc the LED mailining list. >>> >>> That's the discussion of the version 2: >>> >>> https://lkml.org/lkml/2016/9/12/380 >>> >>> Rob, Jacek, could you please agree where I can put the binding? >> >> I'm not sure if this is a good approach. I've noticed also that >> backlight bindings have been moved to leds, whereas they don't look >> similarly. >> >> We have common.txt LED bindings, that all LED class drivers' bindings >> have to follow. Neither backlight bindings nor these ones do that, >> which introduces some mess. > > And there are probably LED bindings that don't follow common.txt either. > >> Eventually adding a sub-directory, e.g. remote_control could make it >> somehow logically justified, but still - shouldn't bindings be >> placed in the documentation directory related to the subsystem of the >> driver they are predestined to? > > No. While binding directories often mirror the driver directories, they > are not the same. Bindings are grouped by types of h/w and IR LEDs are a > type of LED. > > If you prefer a sub-dir, that is fine with me. Fine. So how about sub-dir "ir" ? -- Best regards, Jacek Anaszewski