From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753518Ab1K1PBq (ORCPT ); Mon, 28 Nov 2011 10:01:46 -0500 Received: from casper.infradead.org ([85.118.1.10]:55708 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921Ab1K1PBp convert rfc822-to-8bit (ORCPT ); Mon, 28 Nov 2011 10:01:45 -0500 Message-ID: <1322492478.2921.145.camel@twins> Subject: Re: [PATCH v7 3.2-rc2 9/30] uprobes: Background page replacement. From: Peter Zijlstra To: Srikar Dronamraju Cc: Linus Torvalds , Oleg Nesterov , Andrew Morton , LKML , Linux-mm , Ingo Molnar , Andi Kleen , Christoph Hellwig , Steven Rostedt , Roland McGrath , Thomas Gleixner , Masami Hiramatsu , Arnaldo Carvalho de Melo , Anton Arapov , Ananth N Mavinakayanahalli , Jim Keniston , Stephen Wilson Date: Mon, 28 Nov 2011 16:01:18 +0100 In-Reply-To: <20111118110823.10512.74338.sendpatchset@srdronam.in.ibm.com> References: <20111118110631.10512.73274.sendpatchset@srdronam.in.ibm.com> <20111118110823.10512.74338.sendpatchset@srdronam.in.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.2.1- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2011-11-18 at 16:38 +0530, Srikar Dronamraju wrote: > > Provides Background page replacement by > - cow the page that needs replacement. > - modify a copy of the cowed page. > - replace the cow page with the modified page > - flush the page tables. > > Also provides additional routines to read an opcode from a given virtual > address and for verifying if a instruction is a breakpoint instruction. You again/still lost the reason why we duplicate bits of mm/ksm.c here.