From: Che-Liang Chiou <clchiou@chromium.org>
To: dmitry.torokhov@gmail.com
Cc: linux-kernel@vger.kernel.org, Che-Liang Chiou <clchiou@chromium.org>
Subject: [PATCH 2/2] Input: serio_raw - return error code instead of written on error
Date: Fri, 6 Jan 2012 19:03:15 +0800 [thread overview]
Message-ID: <1325847795-30486-2-git-send-email-clchiou@chromium.org> (raw)
In-Reply-To: <1325847795-30486-1-git-send-email-clchiou@chromium.org>
Even if an error occurs and error code is set, serio_raw_write() returns
the amount of bytes written anyway.
If this behavior is actually desirable, serio_raw_write() should not
even bother to set the error code because it is not intended to be
returned to the caller.
Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
---
drivers/input/serio/serio_raw.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c
index a935c38..32416f7 100644
--- a/drivers/input/serio/serio_raw.c
+++ b/drivers/input/serio/serio_raw.c
@@ -224,7 +224,7 @@ static ssize_t serio_raw_write(struct file *file, const char __user *buffer,
out:
mutex_unlock(&serio_raw_mutex);
- return written;
+ return retval ?: written;
}
static unsigned int serio_raw_poll(struct file *file, poll_table *wait)
--
1.7.3.1
next prev parent reply other threads:[~2012-01-06 11:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 11:03 [PATCH 1/2] Input: serio_raw - cosmetic fixes Che-Liang Chiou
2012-01-06 11:03 ` Che-Liang Chiou [this message]
2012-01-09 8:27 ` [PATCH 2/2] Input: serio_raw - return error code instead of written on error Dmitry Torokhov
2012-01-10 8:27 ` Che-liang Chiou
2012-01-09 8:24 ` [PATCH 1/2] Input: serio_raw - cosmetic fixes Dmitry Torokhov
2012-01-10 8:24 ` Che-liang Chiou
2012-01-10 8:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325847795-30486-2-git-send-email-clchiou@chromium.org \
--to=clchiou@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).