From: Ian Campbell <Ian.Campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jan Beulich <JBeulich@suse.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>
Subject: Re: [Xen-devel] [PATCH 4/5] xen/pciback: Expand the warning message to include domain id.
Date: Mon, 9 Jan 2012 09:50:57 +0000 [thread overview]
Message-ID: <1326102657.17210.11.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <20120106221927.GA10248@phenom.dumpdata.com>
On Fri, 2012-01-06 at 22:19 +0000, Konrad Rzeszutek Wilk wrote:
> > > I suppose you might want "Overriding ownership to dom%d".
> >
> > OK. To the point and potentially can fit in 80 lines :-).
>
> how about this?
> >
> From a3d4a80cdfd4274016522572148a89260b3f3de6 Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Date: Wed, 4 Jan 2012 14:16:45 -0500
> Subject: [PATCH] xen/pciback: Expand the warning message to include domain
> id.
>
> When a PCI device is transferred to another domain and it is still
> in usage (from the internal perspective), mention which other
> domain is using it to aid in debugging.
>
> [v2: Truncate the verbose message per Jan Beulich suggestion]
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> drivers/xen/xen-pciback/xenbus.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
> index 474d52e..2405a24 100644
> --- a/drivers/xen/xen-pciback/xenbus.c
> +++ b/drivers/xen/xen-pciback/xenbus.c
> @@ -243,8 +243,8 @@ static int xen_pcibk_export_device(struct xen_pcibk_device *pdev,
> dev_dbg(&dev->dev, "registering for %d\n", pdev->xdev->otherend_id);
> if (xen_register_device_domain_owner(dev,
> pdev->xdev->otherend_id) != 0) {
> - dev_err(&dev->dev, "device has been assigned to another " \
> - "domain! Over-writting the ownership, but beware.\n");
> + dev_err(&dev->dev, "Overriding ownership to dom%d.\n",
> + xen_find_device_domain_owner(dev));
That sounds like you are going to be assigning the ownership to that
dom, but xen_find_device_domain_owner so aren't you actually steeling
ownership from that domain?
> xen_unregister_device_domain_owner(dev);
> xen_register_device_domain_owner(dev, pdev->xdev->otherend_id);
> }
next prev parent reply other threads:[~2012-01-09 9:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 0:46 [PATCH] Support Function Level Reset (FLR) in the xen-pciback module (v1) and some fixes Konrad Rzeszutek Wilk
2012-01-05 0:46 ` [PATCH 1/5] pci: Introduce __pci_reset_function_locked to be used when holding device_lock Konrad Rzeszutek Wilk
2012-01-05 0:46 ` [PATCH 2/5] xen/pciback: Support pci_reset_function, aka FLR or D3 support Konrad Rzeszutek Wilk
2012-01-05 10:24 ` [Xen-devel] " Ian Campbell
2012-01-05 18:58 ` Don Dutile
2012-01-05 21:34 ` Konrad Rzeszutek Wilk
2012-01-06 16:53 ` Don Dutile
2012-01-06 16:17 ` Konrad Rzeszutek Wilk
2012-01-05 0:46 ` [PATCH 3/5] xen/pciback: Move the PCI_DEV_FLAGS_ASSIGNED ops to the "[un|]bind" Konrad Rzeszutek Wilk
2012-01-05 0:46 ` [PATCH 4/5] xen/pciback: Expand the warning message to include domain id Konrad Rzeszutek Wilk
2012-01-06 8:38 ` [Xen-devel] " Jan Beulich
2012-01-06 15:03 ` Konrad Rzeszutek Wilk
2012-01-06 15:50 ` Keir Fraser
2012-01-06 15:51 ` Ian Campbell
2012-01-06 16:00 ` Konrad Rzeszutek Wilk
2012-01-06 22:19 ` Konrad Rzeszutek Wilk
2012-01-09 9:29 ` Jan Beulich
2012-01-09 9:50 ` Ian Campbell [this message]
2012-01-09 15:11 ` Konrad Rzeszutek Wilk
2012-01-09 15:16 ` Ian Campbell
2012-01-09 15:22 ` Konrad Rzeszutek Wilk
2012-01-05 0:46 ` [PATCH 5/5] xen/pciback: Fix "device has been assigned to X domain!" warning Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326102657.17210.11.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=jbarnes@virtuousgeek.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).