From: Richard Zhao <richard.zhao@linaro.org>
To: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Cc: <dan.j.williams@intel.com>, <vinod.koul@intel.com>,
<shawn.guo@linaro.org>, <kernel@pengutronix.de>,
<eric.miao@linaro.org>, <patches@linaro.org>,
Richard Zhao <richard.zhao@linaro.org>
Subject: [PATCH v2 5/6] dma/imx-sdma: use num_events to validate event_id0
Date: Fri, 13 Jan 2012 11:10:00 +0800 [thread overview]
Message-ID: <1326424201-20056-6-git-send-email-richard.zhao@linaro.org> (raw)
In-Reply-To: <1326424201-20056-1-git-send-email-richard.zhao@linaro.org>
event number is not always 32. use num_events for checking instead.
Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
---
drivers/dma/imx-sdma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 015d93f..22fd561 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -723,7 +723,7 @@ static int sdma_config_channel(struct sdma_channel *sdmac)
sdmac->per_addr = 0;
if (sdmac->event_id0) {
- if (sdmac->event_id0 > 32)
+ if (sdmac->event_id0 >= sdmac->sdma->num_events)
return -EINVAL;
sdma_event_enable(sdmac, sdmac->event_id0);
}
--
1.7.5.4
next prev parent reply other threads:[~2012-01-13 3:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 3:09 [PATCH v2 0/6] imx-sdma: patches when I enable imx6q sabrelite audio Richard Zhao
2012-01-13 3:09 ` [PATCH v2 1/6] dma/imx-sdma: let sdma_run_channel call sdma_enable_channel Richard Zhao
2012-01-13 3:09 ` [PATCH v2 2/6] dma/imx-sdma: use readl_relaxed/writel_relaxed and use writel when necessary Richard Zhao
2012-01-13 3:09 ` [PATCH v2 3/6] dma/imx-sdma: call sdma_set_channel_priority after sdma_request_channel Richard Zhao
2012-01-13 3:09 ` [PATCH v2 4/6] dma/imx-sdma: move clk_enable out of sdma_request_channel Richard Zhao
2012-01-13 3:10 ` Richard Zhao [this message]
2012-01-13 3:10 ` [PATCH v2 6/6] dma/imx-sdma: convernt to use bit ops Richard Zhao
2012-01-13 3:13 ` [PATCH v2 0/6] imx-sdma: patches when I enable imx6q sabrelite audio Richard Zhao
2012-01-31 3:35 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326424201-20056-6-git-send-email-richard.zhao@linaro.org \
--to=richard.zhao@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=eric.miao@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).