From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org,
joseph.cihula@intel.com, linux-acpi@vger.kernel.org,
tboot-devel@lists.sourceforge.net, len.brown@intel.com,
rjw@sisk.pl, mingo@redhat.com
Subject: [PATCH] cleanups in ACPI - removing tboot_ calls for 3.4 (v1)
Date: Tue, 17 Jan 2012 15:50:06 -0500 [thread overview]
Message-ID: <1326833408-23685-1-git-send-email-konrad.wilk@oracle.com> (raw)
I am not really sure if these patches should go through the ACPI or x86 tree.
I think they are more x86-ish related and earlier patches for tboot went through
tip.. Thoughts?
Theset two patches cleanup the ACPI code by removing the 'tboot_sleep'
function call within the ACPI call and instead use a function call.
The function call is set if Intel TXT is detected, otherwise we just skip over
and continue on in hwsleep.c.
Tested on AMD, Intel w/TXT and w/o TXT. Also compile tested on IA64 which has
some reference to tboot but does not use it.
The diff-stat:
arch/x86/kernel/tboot.c | 9 ++++++---
drivers/acpi/acpica/hwsleep.c | 10 +++++++---
drivers/acpi/osl.c | 24 ++++++++++++++++++++++++
include/acpi/acexcep.h | 1 +
include/linux/acpi.h | 10 ++++++++++
include/linux/tboot.h | 1 -
6 files changed, 48 insertions(+), 7 deletions(-)
The purpose of this cleanup is two-fold:
1). Cleanup the call a bit - that 'tboot_sleep' in ACPICA, which is suppose to be
OS-agnostic code looks odd.
2). Piggy-back on the function call if running under Xen [https://lkml.org/lkml/2011/12/16/447].
Those patches are still going through review, but the cleanup patches
can be submitted as standalone.
Thanks!
next reply other threads:[~2012-01-17 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 20:50 Konrad Rzeszutek Wilk [this message]
2012-01-17 20:50 ` [PATCH 1/2] x86, acpi, tboot: Have a ACPI os prepare sleep instead of calling tboot_sleep Konrad Rzeszutek Wilk
2012-01-17 20:50 ` [PATCH 2/2] tboot: Add return values for tboot_sleep Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326833408-23685-1-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=joseph.cihula@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@sisk.pl \
--cc=tboot-devel@lists.sourceforge.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).