linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Mike Galbraith <efault@gmx.de>
Cc: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>
Subject: Re: [PATCH RT 2/4] wait-simple: Simple waitqueue implementation
Date: Wed, 18 Jan 2012 07:45:03 -0500	[thread overview]
Message-ID: <1326890703.17534.76.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1326878928.7482.2.camel@marge.simson.net>

On Wed, 2012-01-18 at 10:28 +0100, Mike Galbraith wrote:
> > +
> > +void __init_swait_head(struct swait_head *head, struct lock_class_key *key)
> > +{
> > +	raw_spin_lock_init(&head->lock);
> > +	lockdep_set_class(&head->lock, key);
> > +	INIT_LIST_HEAD(&head->list);
> > +}
> > +EXPORT_SYMBOL_GPL(__init_swait_head);
> 
> #include <linux/module.h> ?

Did it fail to compile for you?  The 3.2 version included linux/export.h
which didn't exist, and that failed the compile for me. I removed it an
it compiled fine. But perhaps I should have replaced it with module.h.
I'll look into it.

Thanks!

-- Steve



  reply	other threads:[~2012-01-18 12:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18  3:45 [PATCH RT 0/4] [ANNOUNCE] 3.0.14-rt32-rc1 Steven Rostedt
2012-01-18  3:45 ` [PATCH RT 1/4] sched: ttwu: Return success when only changing the saved_state value Steven Rostedt
2012-01-18  3:45 ` [PATCH RT 2/4] wait-simple: Simple waitqueue implementation Steven Rostedt
2012-01-18  9:28   ` Mike Galbraith
2012-01-18 12:45     ` Steven Rostedt [this message]
2012-01-18 13:40       ` Mike Galbraith
2012-01-18 15:39         ` Steven Rostedt
2012-01-18  3:45 ` [PATCH RT 3/4] acpi-gpe-use-wait-simple.patch Steven Rostedt
2012-01-18  3:45 ` [PATCH RT 4/4] Linux 3.0.14-rt32-rc1 Steven Rostedt
2012-01-18  4:21 ` [PATCH RT 0/4] [ANNOUNCE] 3.0.14-rt32-rc1 Steven Rostedt
2012-01-18 13:50 ` Tim Sander
2012-01-18 15:41   ` Steven Rostedt
2012-01-24  8:40     ` Tim Sander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326890703.17534.76.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=efault@gmx.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).