linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Glauber Costa <glommer@parallels.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [BUG] vmstat reports no interrupts
Date: Thu, 19 Jan 2012 21:40:16 +0100	[thread overview]
Message-ID: <1327005616.4826.4.camel@edumazet-laptop> (raw)
In-Reply-To: <20120114000101.GL1068@n2100.arm.linux.org.uk>

Le samedi 14 janvier 2012 à 00:01 +0000, Russell King - ARM Linux a
écrit :
> From: Russell King <rmk+kernel@arm.linux.org.uk>
> proc: fix /proc/stat intr sum
> 
> Commit 3292beb340c7688 (sched/accounting: Change cpustat fields to an array)
> deleted the code which provides us with the sum of all interrupts in
> the system, causing vmstat to report zero interrupts occuring in the
> system.  Fix this by restoring the code.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Tested-by: Russell King <rmk+kernel@arm.linux.org.uk> [on ARM]
> ---
>  fs/proc/stat.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/proc/stat.c b/fs/proc/stat.c
> index d76ca6a..121f77c 100644
> --- a/fs/proc/stat.c
> +++ b/fs/proc/stat.c
> @@ -77,6 +77,8 @@ static int show_stat(struct seq_file *p, void *v)
>  		steal += kcpustat_cpu(i).cpustat[CPUTIME_STEAL];
>  		guest += kcpustat_cpu(i).cpustat[CPUTIME_GUEST];
>  		guest_nice += kcpustat_cpu(i).cpustat[CPUTIME_GUEST_NICE];
> +		sum += kstat_cpu_irqs_sum(i);
> +		sum += arch_irq_stat_cpu(i);
>  
>  		for (j = 0; j < NR_SOFTIRQS; j++) {
>  			unsigned int softirq_stat = kstat_softirqs_cpu(j, i);
> 

Any news on this patch being accepted and pushed to Linus ?

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

Thanks



  parent reply	other threads:[~2012-01-19 20:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-14  0:01 [BUG] vmstat reports no interrupts Russell King - ARM Linux
2012-01-14  0:19 ` Tony Luck
2012-01-14  0:26 ` Steven Rostedt
2012-01-19 20:40 ` Eric Dumazet [this message]
2012-01-21  8:09   ` Ingo Molnar
2012-01-21  9:20     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327005616.4826.4.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=glommer@parallels.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).