From: "Arve Hjønnevåg" <arve@android.com>
To: linux-kernel@vger.kernel.org
Cc: "Al Viro" <viro@ZenIV.linux.org.uk>,
"Arve Hjønnevåg" <arve@android.com>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"Christopher Lais" <chris+android@zenthought.org>,
devel@driverdev.osuosl.org
Subject: [PATCH 2/2] Staging: android: binder: Don't call dump_stack in binder_vma_open
Date: Fri, 20 Jan 2012 19:56:21 -0800 [thread overview]
Message-ID: <1327118181-3542-3-git-send-email-arve@android.com> (raw)
In-Reply-To: <1327118181-3542-1-git-send-email-arve@android.com>
If user-space partially unmaps the driver, binder_vma_open
would dump the kernel stack. This is not a kernel bug however
and will be treated as if the whole area was unmapped once
binder_vma_close gets called.
Signed-off-by: Arve Hjønnevåg <arve@android.com>
---
drivers/staging/android/binder.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 846b429..f0b7e66 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -2765,7 +2765,6 @@ static void binder_vma_open(struct vm_area_struct *vma)
proc->pid, vma->vm_start, vma->vm_end,
(vma->vm_end - vma->vm_start) / SZ_1K, vma->vm_flags,
(unsigned long)pgprot_val(vma->vm_page_prot));
- dump_stack();
}
static void binder_vma_close(struct vm_area_struct *vma)
--
1.7.7.3
prev parent reply other threads:[~2012-01-21 3:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 3:56 [PATCH 0/2] Binder bug fixes Arve Hjønnevåg
2012-01-21 3:56 ` [PATCH 1/2] Staging: android: binder: Add some error checks Arve Hjønnevåg
2012-01-21 8:22 ` Dan Carpenter
2012-01-31 18:52 ` Greg KH
2012-01-31 23:20 ` Arve Hjønnevåg
2012-02-01 6:53 ` Dan Carpenter
2012-02-01 22:29 ` Arve Hjønnevåg
2012-02-01 22:47 ` Greg KH
2012-02-01 23:29 ` [PATCH] Staging: android: binder: Fix crashes when sharing a binder file between processes Arve Hjønnevåg
2012-02-02 6:27 ` [PATCH 1/2] Staging: android: binder: Add some error checks Dan Carpenter
2012-01-21 3:56 ` Arve Hjønnevåg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327118181-3542-3-git-send-email-arve@android.com \
--to=arve@android.com \
--cc=chris+android@zenthought.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).