From: Ian Campbell <Ian.Campbell@citrix.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"annie.li@oracle.com" <annie.li@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Xen-devel] Regressions in v3.3-rc1 introduced by "xen/granttable: Grant tables V2 implementation"
Date: Wed, 25 Jan 2012 15:51:46 +0000 [thread overview]
Message-ID: <1327506706.24561.338.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <45B8991A987A4149B40F1A061BF49097CBE27F2A88@LONPMAILBOX01.citrite.net>
On Wed, 2012-01-25 at 15:47 +0000, Ian Campbell wrote:
> On Wed, 2012-01-25 at 15:16 +0000, Paul Durrant wrote:
> > > -----Original Message-----
> > >
> > > On HVM for gnttab_shared we make an add_to_physmap call with
> > > XENMAPSPACE_grant_table (in gnttab_map). I don't see any support call to
> > > do something similar for the status array though and I don't see a
> > > XENMAPSPACE_* specifically for that case either in the hypervisor either.
> > >
> >
> > There is no map-space for the status pages. To map them you use the
> > standard map space but OR a bit (top bit IIRC) into in the idx. It's a
> > bit icky, but that's how it is.
>
> I can't see that happening anywhere in the current Linux tree, there's
> only one call to XENMAPSPACE_grant_table and it doesn't set the top bit,
> so presumably this is at least part of the problem.
>
> I hope that "top bit" is consistent for 32 and 64 bit domains....
#define XENMAPIDX_grant_table_status 0x80000000
...so yes
Ian.
next prev parent reply other threads:[~2012-01-25 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 4:49 Regressions in v3.3-rc1 introduced by "xen/granttable: Grant tables V2 implementation" Konrad Rzeszutek Wilk
2012-01-25 5:12 ` Konrad Rzeszutek Wilk
2012-01-25 9:55 ` Ian Campbell
2012-01-25 15:16 ` [Xen-devel] " Paul Durrant
2012-01-25 15:47 ` Ian Campbell
[not found] ` <45B8991A987A4149B40F1A061BF49097CBE27F2A88@LONPMAILBOX01.citrite.net>
2012-01-25 15:51 ` Ian Campbell [this message]
2012-01-25 15:23 ` Paul Durrant
2012-01-25 15:49 ` Ian Campbell
2012-01-25 20:50 ` Konrad Rzeszutek Wilk
2012-01-25 22:34 ` Ian Campbell
2012-01-25 20:46 ` Konrad Rzeszutek Wilk
2012-01-25 22:30 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327506706.24561.338.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=annie.li@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).