linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: joeyli <jlee@suse.com>
To: Ike Panhc <ike.pan@canonical.com>
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Merlin Schumacher <merlin.schumacher@gmail.com>,
	Joey Lee <jlee@novell.com>, Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH] acer-wmi: support for P key on TM8372
Date: Thu, 26 Jan 2012 10:28:41 +0800	[thread overview]
Message-ID: <1327544921.15260.7.camel@linux-s257.site> (raw)
In-Reply-To: <1327350935-19145-1-git-send-email-ike.pan@canonical.com>

Hi Ike,

於 二，2012-01-24 於 04:35 +0800，Ike Panhc 提到：
> From: Merlin Schumacher <merlin.schumacher@gmail.com>
> 
> BugLink: http://launchpad.net/bugs/865807
> 
> There is no entry for P key on TM8372, so when P key is pressed, only
> "acer_wmi: Unknown key number - 0x29" in dmesg.
> 
> Signed-off-by: Merlin Schumacher <merlin.schumacher@gmail.com>
> Signed-off-by: Ike Panhc <ike.pan@canonical.com>

Reviewed-by: Lee, Chun-Yi <jlee@suse.com>

> ---
>  drivers/platform/x86/acer-wmi.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index b848277..d48262c 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -105,6 +105,7 @@ static const struct key_entry acer_wmi_keymap[] = {
>  	{KE_KEY, 0x22, {KEY_PROG2} },    /* Arcade */
>  	{KE_KEY, 0x23, {KEY_PROG3} },    /* P_Key */
>  	{KE_KEY, 0x24, {KEY_PROG4} },    /* Social networking_Key */
> +	{KE_KEY, 0x29, {KEY_PROG3} },    /* P_Key for TM8372 */
>  	{KE_IGNORE, 0x41, {KEY_MUTE} },
>  	{KE_IGNORE, 0x42, {KEY_PREVIOUSSONG} },
>  	{KE_IGNORE, 0x43, {KEY_NEXTSONG} },

This patch has no problem, but could you please provide the dmidecode
result to me for reference?


Thanks a lot!
Joey Lee


  reply	other threads:[~2012-01-26  2:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-23 20:35 [PATCH] acer-wmi: support for P key on TM8372 Ike Panhc
2012-01-26  2:28 ` joeyli [this message]
2012-01-26 11:53   ` Merlin Schumacher
2012-02-06 10:08 Joey Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327544921.15260.7.camel@linux-s257.site \
    --to=jlee@suse.com \
    --cc=ike.pan@canonical.com \
    --cc=jlee@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=merlin.schumacher@gmail.com \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).