From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Alexander van Heukelum <heukelum@fastmail.fm>,
Andi Kleen <ak@linux.intel.com>, Oleg Nesterov <oleg@redhat.com>,
Clark Williams <williams@redhat.com>,
Luis Goncalves <lgoncalv@redhat.com>
Subject: Re: [PATCH RT 1/2 v2] x86: Do not disable preemption in int3 on 32bit
Date: Thu, 26 Jan 2012 08:33:31 -0500 [thread overview]
Message-ID: <1327584811.22710.80.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4F211126.1090204@hitachi.com>
On Thu, 2012-01-26 at 17:39 +0900, Masami Hiramatsu wrote:
> (2012/01/25 23:32), Steven Rostedt wrote:
> > Preemption must be disabled before enabling interrupts in do_trap
> > on x86_64 because the stack in use for int3 and debug is a per CPU
> > stack set by th IST. But in 32bit, the stack still belongs to the
> > current task and there is no problem in scheduling out the task.
> >
> > Keep preemption enabled on X86_32 when enabling interrupts for
> > do_trap().
> >
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> Hmm, I think you'd better change caller side, because the
> function itself has "preempt" in its name. I think it can
> easily mislead other people.
How about if we rename it to
conditional_preempt_sti/cli() ?
Then it can be both a conditional preempt as well as interrupts being
disabled. The condition on preempt is "is 32 bits? don't preempt :
preempt";
-- Steve
next prev parent reply other threads:[~2012-01-26 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 14:32 [PATCH RT 0/2 v2] preempt-rt/x86: Handle sending signals from do_trap() by gdb Steven Rostedt
2012-01-25 14:32 ` [PATCH RT 1/2 v2] x86: Do not disable preemption in int3 on 32bit Steven Rostedt
2012-01-26 8:39 ` Masami Hiramatsu
2012-01-26 13:33 ` Steven Rostedt [this message]
2012-01-26 13:59 ` Masami Hiramatsu
2012-01-26 14:21 ` Steven Rostedt
2012-01-27 9:36 ` Masami Hiramatsu
2012-01-25 14:32 ` [PATCH RT 2/2 v2] preempt-rt/x86: Delay calling signals in int3 Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327584811.22710.80.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=jkacur@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).