From: Peter Zijlstra <peterz@infradead.org>
To: Akihiro Nagai <akihiro.nagai.hw@hitachi.com>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
David Ahern <dsahern@gmail.com>,
linux-kernel@vger.kernel.org,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
yrl.pp-manager.tt@hitachi.com, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH -tip v5 2/5] perf: set correct value to perf_event_header.misc for BTS
Date: Mon, 30 Jan 2012 10:35:38 +0100 [thread overview]
Message-ID: <1327916138.2446.187.camel@twins> (raw)
In-Reply-To: <20120130044303.2384.63515.stgit@linux3>
On Mon, 2012-01-30 at 13:43 +0900, Akihiro Nagai wrote:
> @@ -330,6 +342,14 @@ int intel_pmu_drain_bts_buffer(void)
> return 1;
>
> for (; at < top; at++) {
> + /*
> + * To resolve user space symbols and DSOs correctly, set
> + * PERF_RECORD_MISC_USER if from_addr or to_addr is user space.
> + */
> + if (!kernel_ip(data.ip) || !kernel_ip(data.addr)) {
> + header.misc &= ~PERF_RECORD_MISC_CPUMODE_MASK;
> + header.misc |= PERF_RECORD_MISC_USER;
> + }
> data.ip = at->from;
> data.addr = at->to;
Why not key off of the from? If its a jump from userspace its a user
event, its a jump from kernel space its a kernel event?
next prev parent reply other threads:[~2012-01-30 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 4:42 [PATCH -tip v5 0/5] perf script: add BTS analysis features Akihiro Nagai
2012-01-30 4:42 ` [PATCH -tip v5 1/5] perf-script: unify the expressions indicate "unknown" Akihiro Nagai
2012-01-31 13:17 ` [tip:perf/core] perf script: Unify the expressions indicating " unknown" tip-bot for Akihiro Nagai
2012-01-30 4:43 ` [PATCH -tip v5 2/5] perf: set correct value to perf_event_header.misc for BTS Akihiro Nagai
2012-01-30 9:35 ` Peter Zijlstra [this message]
2012-02-21 5:39 ` Akihiro Nagai
2012-03-06 17:32 ` Peter Zijlstra
2012-03-16 2:22 ` Akihiro Nagai
2012-01-30 4:43 ` [PATCH -tip v5 3/5] perf script: print branch_from and branch_to of BTS events Akihiro Nagai
2012-01-31 13:18 ` [tip:perf/core] perf script: Print " tip-bot for Akihiro Nagai
2012-01-30 4:43 ` [PATCH -tip v5 4/5] perf script: add the offset field specifier Akihiro Nagai
2012-01-31 13:19 ` [tip:perf/core] perf script: Add " tip-bot for Akihiro Nagai
2012-01-30 4:43 ` [PATCH -tip v5 5/5] perf script: add option resolving vmlinux path Akihiro Nagai
2012-01-31 13:20 ` [tip:perf/core] perf script: Add " tip-bot for Akihiro Nagai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327916138.2446.187.camel@twins \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=akihiro.nagai.hw@hitachi.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).