linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Jason Baron <jbaron@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 0/5 v2] [GIT PULL] x86/jump label: Paranoid checks and 2 or 5 byte nops
Date: Mon, 30 Jan 2012 10:07:40 -0500	[thread overview]
Message-ID: <1327936060.22710.165.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20120130144857.GA22013@elte.hu>

On Mon, 2012-01-30 at 15:48 +0100, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > 
> > Ingo,
> > 
> > This is the second round with the suggestions made by Peter 
> > and Andrew incorporated (and tested).
> 
> they are crashing my testbox:
> 
> Policy zone: DMA32
> Kernel command line: root=/dev/sda6 earlyprintk=ttyS0,115200 
> console=ttyS0,115200 debug initcall_de
> bug sysrq_always_enabled ignore_loglevel selinux=0 
> nmi_watchdog=1 panic=1 3
> sysrq: sysrq always enabled.
> PANIC: early exception 06 rip 10:ffffffff8101546d error 0 cr2 
> f06f53
> Pid: 0, comm: swapper Not tainted 
> 3.3.0-rc1-tip-02083-ga5066f8-dirty #170372
> Call Trace:
>  [<ffffffff8101546d>] ? __jump_label_transform+0x81/0x14e
>  [<ffffffff81063ee4>] ? try_to_wake_up+0x1f8/0x2cc
>  [<ffffffff8184d19e>] early_idt_handler+0x5e/0x71
>  [<ffffffff8101546d>] ? __jump_label_transform+0x81/0x14e
>  [<ffffffff81015457>] ? __jump_label_transform+0x6b/0x14e
>  [<ffffffff810155f8>] arch_jump_label_transform_static+0x6f/0x77
>  [<ffffffff81865162>] jump_label_init+0x68/0x98
>  [<ffffffff8184d98b>] start_kernel+0x182/0x3b8
>  [<ffffffff8184d2c3>] x86_64_start_reservations+0xae/0xb2
>  [<ffffffff8184d40d>] x86_64_start_kernel+0x146/0x153
> RIP __jump_label_transform+0x81/0x14e
> 
> Do you need the config or is the bug obvious at first sight?

Could you post the exact line of that address?

<ffffffff8101546d>

I know there was some work to default enable some code. I'm not sure how
much made it in. I'm thinking the line you triggered was:
		/*
		 * The location is not a nop that we were expecting,
		 * something went wrong. Crash the box, as something could be
		 * corrupting the kernel.
		 */
		BUG();


It hits this if we enable a nop that is not what we expect it to be.

Yeah, send me the config too, and I'll run this against tip/master with
all the patches applied.

Thanks!

-- Steve



  reply	other threads:[~2012-01-30 15:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-28 16:09 [PATCH 0/5 v2] [GIT PULL] x86/jump label: Paranoid checks and 2 or 5 byte nops Steven Rostedt
2012-01-28 16:09 ` [PATCH 1/5 v2] x86/jump-label: Use best default nops for inital jump label calls Steven Rostedt
2012-01-28 16:09 ` [PATCH 2/5 v2] x86/jump-label: Do not bother updating nops if they are correct Steven Rostedt
2012-01-28 16:09 ` [PATCH 3/5 v2] x86/jump-label: Add safety checks to jump label conversions Steven Rostedt
2012-01-28 16:09 ` [PATCH 4/5 v2] jump labels: Add infrastructure to update jump labels at compile time Steven Rostedt
2012-01-28 16:09 ` [PATCH 5/5 v2] x86/jump labels: Use etiher 5 byte or 2 byte jumps Steven Rostedt
2012-01-30 14:48 ` [PATCH 0/5 v2] [GIT PULL] x86/jump label: Paranoid checks and 2 or 5 byte nops Ingo Molnar
2012-01-30 15:07   ` Steven Rostedt [this message]
2012-01-31 19:48     ` Ingo Molnar
2012-02-01  5:08       ` Steven Rostedt
2012-02-01  8:05         ` Ingo Molnar
2012-02-01 13:20           ` Steven Rostedt
2012-02-01 15:21           ` Steven Rostedt
2012-02-02 13:51             ` Ingo Molnar
2012-02-02 14:10               ` H. Peter Anvin
2012-02-02 14:31                 ` Steven Rostedt
2012-02-02 22:04                   ` Steven Rostedt
2012-02-02 22:07                     ` H. Peter Anvin
2012-02-02 22:53                       ` Steven Rostedt
2012-02-03  7:36                   ` Ingo Molnar
2012-02-03 13:31                     ` Steven Rostedt
2012-02-05 11:47                       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327936060.22710.165.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).