From: Colin Walters <walters@verbum.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Will Drewry <wad@chromium.org>,
linux-kernel@vger.kernel.org,
Casey Schaufler <casey@schaufler-ca.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jamie Lokier <jamie@shareable.org>,
keescook@chromium.org, john.johansen@canonical.com,
serge.hallyn@canonical.com, coreyb@linux.vnet.ibm.com,
pmoore@redhat.com, eparis@redhat.com, djm@mindrot.org,
segoon@openwall.com, rostedt@goodmis.org, jmorris@namei.org,
scarybeasts@gmail.com, avi@redhat.com, penberg@cs.helsinki.fi,
viro@zeniv.linux.org.uk, mingo@elte.hu,
akpm@linux-foundation.org, khilman@ti.com,
borislav.petkov@amd.com, amwang@redhat.com, oleg@redhat.com,
ak@linux.intel.com, eric.dumazet@gmail.com, gregkh@suse.de,
dhowells@redhat.com, daniel.lezcano@free.fr,
linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org, olofj@chromium.org,
mhalcrow@google.com, dlaor@redhat.com, corbet@lwn.net,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH v3 4/4] Allow unprivileged chroot when safe
Date: Mon, 30 Jan 2012 17:41:47 -0500 [thread overview]
Message-ID: <1327963309.5355.7.camel@lenny> (raw)
In-Reply-To: <CALCETrWqOsWjnJOLD5TytOiSSiRE7wAwo6dRj5A7-jP-zEGa3A@mail.gmail.com>
On Mon, 2012-01-30 at 14:10 -0800, Andy Lutomirski wrote:
> On Mon, Jan 30, 2012 at 1:58 PM, Colin Walters <walters@verbum.org> wrote:
> > On Mon, 2012-01-30 at 08:17 -0800, Andy Lutomirski wrote:
> >> Chroot can easily be used to subvert setuid programs. If no_new_privs,
> >> then setuid programs don't gain any privilege, so allow chroot.
> >
> > Is this needed/desired by anyone now, or are you just using it to "demo"
> > NO_NEW_PRIVS? I don't see it as very useful on its own, since in any
> > "container"-type chroot you really want /proc and /dev, and your patch
> > doesn't help with that.
>
> It's a demo, but it could still be useful for container-ish things.
> If something privileged sets up /proc, /sys, and /dev, then
> unprivileged code can chroot into the container. This would allow
> much simpler implementations of tools like schroot.
What's the win if you still need a setuid binary? schroot (and my
linux-user chroot binary) can just as easily call chroot as they can
create bind mounts; I'm not buying a code complexity argument.
> With this change, they wouldn't need to start privileged.
> (Admittedly, this isn't a great argument for this patch.)
Right...I'm not aware of anyone who would find that useful.
next prev parent reply other threads:[~2012-01-30 22:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 16:17 [PATCH v3 0/4] PR_SET_NO_NEW_PRIVS, unshare, and chroot Andy Lutomirski
2012-01-30 16:17 ` [PATCH v3 1/4] Add PR_{GET,SET}_NO_NEW_PRIVS to prevent execve from granting privs Andy Lutomirski
2012-02-01 18:14 ` Kees Cook
2012-01-30 16:17 ` [PATCH v3 2/4] Fix apparmor for PR_{GET,SET}_NO_NEW_PRIVS Andy Lutomirski
2012-01-30 16:17 ` [PATCH v3 3/4] Allow unprivileged CLONE_NEWUTS and CLONE_NEWIPC with no_new_privs Andy Lutomirski
2012-02-01 19:02 ` Kees Cook
2012-02-01 20:35 ` Andy Lutomirski
2012-01-30 16:17 ` [PATCH v3 4/4] Allow unprivileged chroot when safe Andy Lutomirski
2012-01-30 21:58 ` Colin Walters
2012-01-30 22:10 ` Andy Lutomirski
2012-01-30 22:41 ` Colin Walters [this message]
2012-01-30 22:43 ` Andy Lutomirski
2012-01-30 23:10 ` Colin Walters
2012-01-30 23:15 ` Andy Lutomirski
2012-01-30 23:55 ` Colin Walters
2012-01-31 0:13 ` Andy Lutomirski
2012-01-30 22:18 ` Steven Rostedt
2012-01-30 22:28 ` Andy Lutomirski
2012-01-30 22:38 ` Will Drewry
2012-01-30 22:48 ` Colin Walters
2012-01-30 22:51 ` Andy Lutomirski
2012-02-09 9:35 ` Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327963309.5355.7.camel@lenny \
--to=walters@verbum.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=amwang@redhat.com \
--cc=avi@redhat.com \
--cc=borislav.petkov@amd.com \
--cc=casey@schaufler-ca.com \
--cc=corbet@lwn.net \
--cc=coreyb@linux.vnet.ibm.com \
--cc=daniel.lezcano@free.fr \
--cc=dhowells@redhat.com \
--cc=djm@mindrot.org \
--cc=dlaor@redhat.com \
--cc=eparis@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@suse.de \
--cc=jamie@shareable.org \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=keescook@chromium.org \
--cc=khilman@ti.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mhalcrow@google.com \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=olofj@chromium.org \
--cc=penberg@cs.helsinki.fi \
--cc=pmoore@redhat.com \
--cc=rostedt@goodmis.org \
--cc=scarybeasts@gmail.com \
--cc=segoon@openwall.com \
--cc=serge.hallyn@canonical.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).