linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Whitcroft <apw@shadowen.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	linux-kernel@vger.kernel.org,
	Pavel Emelyanov <xemul@parallels.com>,
	Serge Hallyn <serge.hallyn@canonical.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Kees Cook <keescook@chromium.org>, Tejun Heo <tj@kernel.org>,
	Andrew Vagin <avagin@openvz.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Andi Kleen <andi@firstfloor.org>,
	KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Glauber Costa <glommer@parallels.com>,
	Matt Helsley <matthltc@us.ibm.com>,
	Pekka Enberg <penberg@kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Vasiliy Kulikov <segoon@openwall.com>,
	Valdis.Kletnieks@vt.edu
Subject: [PATCH] checkpatch: Warn on code with 6+ tab indentation
Date: Fri, 03 Feb 2012 15:20:39 -0800	[thread overview]
Message-ID: <1328311239.21255.24.camel@joe2Laptop> (raw)
In-Reply-To: <CA+55aFxjPAsfsSSOsX9eyts6EP6dEyieGS_YJs-4HLuTKNfzZg@mail.gmail.com>

Overly indented code should be refactored.

Suggest refactoring excessive indentation of
of if/else/for/do/while/switch statements.

For example:

$ cat t.c
#include <stdio.h>
#include <stdlib.h>

int main(int argc, char **argv)
{

	if (1)
		if (2)
			if (3)
				if (4)
					if (5)
						if (6)
							if (7)
								if (8)
									;
	return 0;
}

$ ./scripts/checkpatch.pl -f t.c
WARNING: Too many leading tabs - consider code refactoring
#12: FILE: t.c:12:
+						if (6)

WARNING: Too many leading tabs - consider code refactoring
#13: FILE: t.c:13:
+							if (7)

WARNING: Too many leading tabs - consider code refactoring
#14: FILE: t.c:14:
+								if (8)

total: 0 errors, 3 warnings, 17 lines checked

t.c has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Signed-off-by: Joe Perches <joe@perches.com>
---
On Fri, 2012-02-03 at 13:27 -0800, Linus Torvalds wrote:
> So no, 100-char columns are not ok.

Perhaps this is a reasonable alternative.

Another might be to limit variable name length to something
shorter than say 10 characters.

 scripts/checkpatch.pl |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2b52aeb..89d24b3 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1924,6 +1924,12 @@ sub process {
 			my $pre_ctx = "$1$2";
 
 			my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
+
+			if ($line =~ /^\+\t{6,}/) {
+				WARN("DEEP_INDENTATION",
+				     "Too many leading tabs - consider code refactoring\n" . $herecurr);
+			}
+
 			my $ctx_cnt = $realcnt - $#ctx - 1;
 			my $ctx = join("\n", @ctx);
 



  reply	other threads:[~2012-02-03 23:20 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 14:09 [patch cr 0/4] [patch cr 0/@total@] Cyrill Gorcunov
2012-01-30 14:09 ` [patch cr 1/4] fs, proc: Introduce /proc/<pid>/task/<tid>/children entry v9 Cyrill Gorcunov
2012-01-30 14:09 ` [patch cr 2/4] [RFC] syscalls, x86: Add __NR_kcmp syscall v7 Cyrill Gorcunov
2012-01-30 19:58   ` Jonathan Corbet
2012-01-30 21:07     ` Cyrill Gorcunov
2012-01-30 21:11     ` H. Peter Anvin
2012-02-02 23:26   ` Andrew Morton
2012-02-03  2:27     ` H. Peter Anvin
2012-02-03  7:09       ` Cyrill Gorcunov
2012-02-03  7:46   ` Ingo Molnar
2012-02-03  8:35     ` Cyrill Gorcunov
2012-02-03  9:09       ` Ingo Molnar
2012-02-03  9:22         ` Andrew Morton
2012-02-03  9:28           ` Cyrill Gorcunov
2012-02-03 17:32             ` H. Peter Anvin
2012-02-03 17:35               ` H. Peter Anvin
2012-02-03 17:42                 ` Cyrill Gorcunov
2012-02-03  9:52           ` Ingo Molnar
2012-02-03 10:07             ` [PATCH] SubmittingPatches: Increase the line length limit from 80 to 100 colums Ingo Molnar
2012-02-03 10:17               ` Pekka Enberg
2012-02-03 10:23                 ` Cyrill Gorcunov
2012-02-03 10:40               ` Alexey Dobriyan
2012-02-03 16:13               ` Tejun Heo
2012-02-03 16:39                 ` hpanvin@gmail.com
2012-02-03 17:56               ` Andi Kleen
2012-02-03 20:57               ` Andrew Morton
2012-02-03 21:00                 ` H. Peter Anvin
2012-02-03 21:06                 ` H. Peter Anvin
2012-02-04 13:08                 ` Ingo Molnar
2012-02-03 21:27               ` Linus Torvalds
2012-02-03 23:20                 ` Joe Perches [this message]
2012-02-04  1:27                   ` [PATCH] checkpatch: Warn on code with 6+ tab indentation Linus Torvalds
2012-02-04  1:33                     ` Joe Perches
2012-02-04  3:09                       ` Linus Torvalds
2012-02-04  3:21                         ` Joe Perches
2012-02-04  3:35                           ` Linus Torvalds
2012-02-04  3:58                             ` Joe Perches
2012-02-04  1:37                     ` Andrew Morton
2012-02-04  2:40                   ` Eric W. Biederman
2012-02-04  2:46                     ` Joe Perches
2012-02-04  4:45                   ` Tony Luck
2012-02-04  4:53                     ` Joe Perches
2012-02-04 13:03                   ` [PATCH, v2] checkpatch: Warn on code with 6+ tab indentation, remove 80col warning Ingo Molnar
2012-02-04 16:22                     ` Joe Perches
2012-02-04 18:02                       ` Ingo Molnar
2012-02-04 18:48                         ` Joe Perches
2012-02-04 18:54                           ` Pekka Enberg
2012-02-04 19:27                             ` Joe Perches
2012-02-04 19:32                               ` Pekka Enberg
2012-02-05 11:38                               ` Ingo Molnar
2012-02-05 16:21                                 ` Joe Perches
2012-02-05 18:13                                   ` Ingo Molnar
2012-02-05 19:01                                     ` [PATCH] checkpatch: Add line-length options, set default to 100 Joe Perches
2012-02-06 12:36                                       ` Dan Carpenter
2012-02-04  1:24                 ` [PATCH] SubmittingPatches: Increase the line length limit from 80 to 100 colums Randy Dunlap
2012-02-09 21:55               ` Jan Engelhardt
2012-02-09 22:09                 ` Joe Perches
2012-02-09 22:30                 ` Mark Brown
2012-01-30 14:09 ` [patch cr 3/4] c/r: procfs: add arg_start/end, env_start/end and exit_code members to /proc/$pid/stat Cyrill Gorcunov
2012-02-02 23:26   ` Andrew Morton
2012-02-03  7:11     ` Cyrill Gorcunov
2012-01-30 14:09 ` [patch cr 4/4] c/r: prctl: Extend PR_SET_MM to set up more mm_struct entries Cyrill Gorcunov
2012-02-02 23:27   ` Andrew Morton
2012-02-03  7:18     ` Cyrill Gorcunov
2012-02-02 23:26 ` [patch cr 0/4] [patch cr 0/@total@] Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328311239.21255.24.camel@joe2Laptop \
    --to=joe@perches.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=apw@shadowen.org \
    --cc=avagin@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=eric.dumazet@gmail.com \
    --cc=glommer@parallels.com \
    --cc=gorcunov@openvz.org \
    --cc=hpa@zytor.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=keescook@chromium.org \
    --cc=kosaki.motohiro@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthltc@us.ibm.com \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    --cc=segoon@openwall.com \
    --cc=serge.hallyn@canonical.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=xemul@parallels.com \
    --subject='Re: [PATCH] checkpatch: Warn on code with 6+ tab indentation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).