From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754629Ab2BDExb (ORCPT ); Fri, 3 Feb 2012 23:53:31 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:38945 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751692Ab2BDExa (ORCPT ); Fri, 3 Feb 2012 23:53:30 -0500 Message-ID: <1328331208.21255.51.camel@joe2Laptop> Subject: Re: [PATCH] checkpatch: Warn on code with 6+ tab indentation From: Joe Perches To: Tony Luck Cc: Linus Torvalds , Andy Whitcroft , Ingo Molnar , Andrew Morton , Cyrill Gorcunov , linux-kernel@vger.kernel.org, Pavel Emelyanov , Serge Hallyn , KAMEZAWA Hiroyuki , Kees Cook , Tejun Heo , Andrew Vagin , "Eric W. Biederman" , Alexey Dobriyan , Andi Kleen , KOSAKI Motohiro , "H. Peter Anvin" , Thomas Gleixner , Glauber Costa , Matt Helsley , Pekka Enberg , Eric Dumazet , Vasiliy Kulikov , Valdis.Kletnieks@vt.edu Date: Fri, 03 Feb 2012 20:53:28 -0800 In-Reply-To: References: <20120130140905.441199885@openvz.org> <20120130141852.309402052@openvz.org> <20120203074656.GC30543@elte.hu> <20120203083530.GD1968@moon> <20120203090929.GA23996@elte.hu> <20120203012241.bcd3d0c8.akpm@linux-foundation.org> <20120203095227.GA13162@elte.hu> <20120203100743.GA3334@elte.hu> <1328311239.21255.24.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-02-03 at 20:45 -0800, Tony Luck wrote: > On Fri, Feb 3, 2012 at 3:20 PM, Joe Perches wrote: > > Another might be to limit variable name length to something > > shorter than say 10 characters. > > 10? We have a few cases of variables over 100 (not sure how you are supposed > to use them with an 80 character max line length). Current longest is: > > eOpenLogicalChannelAck_reverseLogicalChannelParameters_multiplexParameters_h2250LogicalChannelParameters EUey. (err, well maybe ITUey) Remind me never to look at that code again.