From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035Ab2BDQWV (ORCPT ); Sat, 4 Feb 2012 11:22:21 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:38174 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751927Ab2BDQWU (ORCPT ); Sat, 4 Feb 2012 11:22:20 -0500 Message-ID: <1328372536.5766.3.camel@joe2Laptop> Subject: Re: [PATCH, v2] checkpatch: Warn on code with 6+ tab indentation, remove 80col warning From: Joe Perches To: Ingo Molnar Cc: Linus Torvalds , Andy Whitcroft , Andrew Morton , Cyrill Gorcunov , linux-kernel@vger.kernel.org, Pavel Emelyanov , Serge Hallyn , KAMEZAWA Hiroyuki , Kees Cook , Tejun Heo , Andrew Vagin , "Eric W. Biederman" , Alexey Dobriyan , Andi Kleen , KOSAKI Motohiro , "H. Peter Anvin" , Thomas Gleixner , Glauber Costa , Matt Helsley , Pekka Enberg , Eric Dumazet , Vasiliy Kulikov , Valdis.Kletnieks@vt.edu Date: Sat, 04 Feb 2012 08:22:16 -0800 In-Reply-To: <20120204130330.GA30198@elte.hu> References: <20120130140905.441199885@openvz.org> <20120130141852.309402052@openvz.org> <20120203074656.GC30543@elte.hu> <20120203083530.GD1968@moon> <20120203090929.GA23996@elte.hu> <20120203012241.bcd3d0c8.akpm@linux-foundation.org> <20120203095227.GA13162@elte.hu> <20120203100743.GA3334@elte.hu> <1328311239.21255.24.camel@joe2Laptop> <20120204130330.GA30198@elte.hu> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2012-02-04 at 14:03 +0100, Ingo Molnar wrote: > * Joe Perches wrote: > > Overly indented code should be refactored. > _AND_ the 80 cols warning should be removed. The overwhelming > majority of developers either ignore the 80 cols warning or make > the code worse as a result of the warning. Perhaps, but it should be a separate patch and you'd still need to update CodingStyle.