From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: "x86@kernel.org" <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH v5 4/5] hwmon: add MAX197 support
Date: Mon, 6 Feb 2012 12:46:04 -0800 [thread overview]
Message-ID: <1328561164.2261.258.camel@groeck-laptop> (raw)
In-Reply-To: <20120206151507.73a23eb8@v0nbox>
Hi Vivien,
On Mon, 2012-02-06 at 15:15 -0500, Vivien Didelot wrote:
[ ... ]
>
> BTW, about the TS-5500 ADC part, is a platform ts5500_adc.c file the
> better solution, or should the device be declared in the ts5500.c
> platform code?
>
I would suggest to declare it in the ts5500.c platform code. That seems
to be the common approach as far as I can see.
platform_add_devices() works pretty well for this. It saves you from
having to call platform_device_register() for each device separately.
Obviously that only works if all devices are declared in a single file.
Thanks,
Guenter
next prev parent reply other threads:[~2012-02-06 20:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 21:05 [PATCH v5 0/5] Support for the TS-5500 platform Vivien Didelot
2012-02-01 21:05 ` [PATCH v5 1/5] x86/platform: (TS-5500) add platform base support Vivien Didelot
2012-02-01 21:05 ` [PATCH v5 2/5] x86/platform: (TS-5500) add GPIO support Vivien Didelot
2012-02-01 21:30 ` Alan Cox
2012-02-02 19:33 ` Guenter Roeck
2012-02-06 15:37 ` Mark Brown
2012-02-06 20:23 ` Vivien Didelot
2012-02-07 11:13 ` Mark Brown
2012-02-06 15:16 ` Mark Brown
2012-02-01 21:05 ` [PATCH v5 3/5] x86/platform: (TS-5500) add LED support Vivien Didelot
2012-02-01 21:05 ` [PATCH v5 4/5] hwmon: add MAX197 support Vivien Didelot
2012-02-01 21:35 ` Guenter Roeck
2012-02-06 20:15 ` Vivien Didelot
2012-02-06 20:46 ` Guenter Roeck [this message]
2012-02-10 16:07 ` Vivien Didelot
2012-02-10 16:15 ` Guenter Roeck
2012-02-10 18:14 ` Vivien Didelot
2012-02-20 18:27 ` Guenter Roeck
2012-02-20 19:56 ` Vivien Didelot
2012-02-01 21:05 ` [PATCH v5 5/5] x86/platform: (TS-5500) add ADC support Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328561164.2261.258.camel@groeck-laptop \
--to=guenter.roeck@ericsson.com \
--cc=hpa@zytor.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).