From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org
Cc: Michal Nazarewicz <mina86@mina86.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daniel Walker <dwalker@codeaurora.org>,
Mel Gorman <mel@csn.ul.ie>, Arnd Bergmann <arnd@arndb.de>,
Jesse Barker <jesse.barker@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Shariq Hasnain <shariq.hasnain@linaro.org>,
Chunsang Jeong <chunsang.jeong@linaro.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Rob Clark <rob.clark@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>
Subject: [PATCHv21 07/16] mm: page_alloc: change fallbacks array handling
Date: Fri, 10 Feb 2012 18:32:22 +0100 [thread overview]
Message-ID: <1328895151-5196-8-git-send-email-m.szyprowski@samsung.com> (raw)
In-Reply-To: <1328895151-5196-1-git-send-email-m.szyprowski@samsung.com>
From: Michal Nazarewicz <mina86@mina86.com>
This commit adds a row for MIGRATE_ISOLATE type to the fallbacks array
which was missing from it. It also, changes the array traversal logic
a little making MIGRATE_RESERVE an end marker. The letter change,
removes the implicit MIGRATE_UNMOVABLE from the end of each row which
was read by __rmqueue_fallback() function.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Mel Gorman <mel@csn.ul.ie>
Tested-by: Rob Clark <rob.clark@linaro.org>
Tested-by: Ohad Ben-Cohen <ohad@wizery.com>
Tested-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
---
mm/page_alloc.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index f820bfa..f025fba 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -875,11 +875,12 @@ struct page *__rmqueue_smallest(struct zone *zone, unsigned int order,
* This array describes the order lists are fallen back to when
* the free lists for the desirable migrate type are depleted
*/
-static int fallbacks[MIGRATE_TYPES][MIGRATE_TYPES-1] = {
+static int fallbacks[MIGRATE_TYPES][3] = {
[MIGRATE_UNMOVABLE] = { MIGRATE_RECLAIMABLE, MIGRATE_MOVABLE, MIGRATE_RESERVE },
[MIGRATE_RECLAIMABLE] = { MIGRATE_UNMOVABLE, MIGRATE_MOVABLE, MIGRATE_RESERVE },
[MIGRATE_MOVABLE] = { MIGRATE_RECLAIMABLE, MIGRATE_UNMOVABLE, MIGRATE_RESERVE },
- [MIGRATE_RESERVE] = { MIGRATE_RESERVE, MIGRATE_RESERVE, MIGRATE_RESERVE }, /* Never used */
+ [MIGRATE_RESERVE] = { MIGRATE_RESERVE }, /* Never used */
+ [MIGRATE_ISOLATE] = { MIGRATE_RESERVE }, /* Never used */
};
/*
@@ -974,12 +975,12 @@ __rmqueue_fallback(struct zone *zone, int order, int start_migratetype)
/* Find the largest possible block of pages in the other list */
for (current_order = MAX_ORDER-1; current_order >= order;
--current_order) {
- for (i = 0; i < MIGRATE_TYPES - 1; i++) {
+ for (i = 0;; i++) {
migratetype = fallbacks[start_migratetype][i];
/* MIGRATE_RESERVE handled later if necessary */
if (migratetype == MIGRATE_RESERVE)
- continue;
+ break;
area = &(zone->free_area[current_order]);
if (list_empty(&area->free_list[migratetype]))
--
1.7.1.569.g6f426
next prev parent reply other threads:[~2012-02-10 17:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 17:32 [PATCHv21 00/16] Contiguous Memory Allocator Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 01/16] mm: page_alloc: remove trailing whitespace Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 02/16] mm: compaction: introduce isolate_migratepages_range() Marek Szyprowski
2012-02-14 7:19 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 03/16] mm: compaction: introduce map_pages() Marek Szyprowski
2012-02-14 7:25 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 04/16] mm: compaction: introduce isolate_freepages_range() Marek Szyprowski
2012-02-14 7:30 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 05/16] mm: compaction: export some of the functions Marek Szyprowski
2012-02-14 7:47 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 06/16] mm: page_alloc: introduce alloc_contig_range() Marek Szyprowski
2012-02-14 7:54 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` Marek Szyprowski [this message]
2012-02-14 7:56 ` [PATCHv21 07/16] mm: page_alloc: change fallbacks array handling KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 08/16] mm: mmzone: MIGRATE_CMA migration type added Marek Szyprowski
2012-02-14 8:29 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 09/16] mm: page_isolation: MIGRATE_CMA isolation functions added Marek Szyprowski
2012-02-14 8:31 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 10/16] mm: Serialize access to min_free_kbytes Marek Szyprowski
2012-02-14 8:38 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 11/16] mm: extract reclaim code from __alloc_pages_direct_reclaim() Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 12/16] mm: trigger page reclaim in alloc_contig_range() to stabilise watermarks Marek Szyprowski
2012-02-13 18:57 ` [Linaro-mm-sig] " Robert Nelson
2012-02-13 19:38 ` Michal Nazarewicz
2012-02-13 21:15 ` Robert Nelson
2012-02-13 21:33 ` Michal Nazarewicz
2012-02-13 21:37 ` Robert Nelson
2012-02-10 17:32 ` [PATCHv21 13/16] drivers: add Contiguous Memory Allocator Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 14/16] X86: integrate CMA with DMA-mapping subsystem Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 15/16] ARM: " Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 16/16] ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328895151-5196-8-git-send-email-m.szyprowski@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benjamin.gaignard@linaro.org \
--cc=chunsang.jeong@linaro.org \
--cc=corbet@lwn.net \
--cc=dave@linux.vnet.ibm.com \
--cc=dwalker@codeaurora.org \
--cc=jesse.barker@linaro.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mel@csn.ul.ie \
--cc=mina86@mina86.com \
--cc=ohad@wizery.com \
--cc=rob.clark@linaro.org \
--cc=shariq.hasnain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).