linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: mingo@redhat.com, hpa@zytor.com, anton.vorontsov@linaro.org,
	arve@android.com, linux-kernel@vger.kernel.org, san@google.com,
	ebiederm@xmission.com, gregkh@linuxfoundation.org,
	paulmck@linux.vnet.ibm.com, ccross@android.com,
	kosaki.motohiro@gmail.com, oleg@redhat.com, tglx@linutronix.de,
	mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched: Turn lock_task_sighand() into a static inline
Date: Wed, 15 Feb 2012 14:52:48 +0100	[thread overview]
Message-ID: <1329313968.2293.109.camel@twins> (raw)
In-Reply-To: <tip-9388dc3047a88bedfd867e9ba3e1980c815ac524@git.kernel.org>

On Sat, 2012-02-11 at 15:10 -0800, tip-bot for Anton Vorontsov wrote:
> +static inline struct sighand_struct *lock_task_sighand(struct task_struct *tsk,
> +                                                      unsigned long *flags)
> +{
> +       struct sighand_struct *ret;
> +
> +       ret = __lock_task_sighand(tsk, flags);
> +       (void)__cond_lock(&tsk->sighand->siglock, ret);
> +       return ret;
> +} 

FWIW, I still really utterly detest __cond_lock(). Ideally someone would
teach sparse the conditional based on return thing and we could do the
function level annotation.

  reply	other threads:[~2012-02-15 13:53 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01  4:33 [PATCH] staging: android/lowmemorykiller: Don't grab tasklist_lock Anton Vorontsov
2012-02-02 12:54 ` Oleg Nesterov
2012-02-02 17:16   ` Anton Vorontsov
2012-02-03  0:03     ` [PATCH v3] " Anton Vorontsov
2012-02-03 16:36       ` Oleg Nesterov
2012-02-03 16:30     ` [PATCH] " Oleg Nesterov
2012-02-06 16:29       ` [PATCH 1/6] oom: Make find_lock_task_mm() sparse-aware Anton Vorontsov
2012-02-06 16:35         ` Greg KH
2012-02-06 18:59           ` Anton Vorontsov
2012-02-06 19:18             ` Greg KH
2012-02-06 21:27               ` KOSAKI Motohiro
2012-02-07  4:48                 ` [PATCH v2 " Anton Vorontsov
2012-02-07  5:17                   ` KOSAKI Motohiro
2012-02-08 15:27                   ` Oleg Nesterov
2012-02-09 16:45                     ` [PATCH] sched: Turn lock_task_sighand() into a static inline Anton Vorontsov
2012-02-11 23:10                       ` [tip:sched/core] " tip-bot for Anton Vorontsov
2012-02-15 13:52                         ` Peter Zijlstra [this message]
2012-02-06 16:29       ` [PATCH 2/6] oom: Get rid of sparse warnings Anton Vorontsov
2012-02-06 21:33         ` KOSAKI Motohiro
2012-02-07  4:20           ` [PATCH v2 " Anton Vorontsov
2012-02-07  5:38             ` KOSAKI Motohiro
2012-02-07  6:23               ` Anton Vorontsov
2012-02-08 18:13                 ` KOSAKI Motohiro
2012-02-06 16:29       ` [PATCH 3/6] staging: android/lowmemorykiller: Don't grab tasklist_lock Anton Vorontsov
2012-02-06 16:36         ` Greg KH
2012-02-06 16:42           ` Anton Vorontsov
2012-02-09  0:56             ` Greg KH
2012-02-08 15:32         ` Oleg Nesterov
2012-02-06 16:29       ` [PATCH 4/6] staging: android/lowmemorykiller: Better mm handling Anton Vorontsov
2012-02-06 21:36         ` KOSAKI Motohiro
2012-02-08 15:34         ` Oleg Nesterov
2012-02-06 16:29       ` [PATCH 5/6] staging: android/lowmemorykiller: No need for task->signal check Anton Vorontsov
2012-02-06 21:38         ` KOSAKI Motohiro
2012-02-08 15:35         ` Oleg Nesterov
2012-02-06 16:30       ` [PATCH 6/6] staging: android/lowmemorykiller: Do not kill kernel threads Anton Vorontsov
2012-02-06 21:38         ` KOSAKI Motohiro
2012-02-08 15:36         ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329313968.2293.109.camel@twins \
    --to=peterz@infradead.org \
    --cc=anton.vorontsov@linaro.org \
    --cc=arve@android.com \
    --cc=ccross@android.com \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=san@google.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).