From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751800Ab2BPQrF (ORCPT ); Thu, 16 Feb 2012 11:47:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9507 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114Ab2BPQrD (ORCPT ); Thu, 16 Feb 2012 11:47:03 -0500 Subject: Re: [PATCH 08/11] gfs2: Push file_update_time() into gfs2_page_mkwrite() From: Steven Whitehouse To: Jan Kara Cc: LKML , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Eric Sandeen , Dave Chinner , cluster-devel@redhat.com In-Reply-To: <1329399979-3647-9-git-send-email-jack@suse.cz> References: <1329399979-3647-1-git-send-email-jack@suse.cz> <1329399979-3647-9-git-send-email-jack@suse.cz> Content-Type: text/plain; charset="UTF-8" Organization: Red Hat UK Ltd Date: Thu, 16 Feb 2012 16:47:20 +0000 Message-ID: <1329410840.2719.27.camel@menhir> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: > CC: Steven Whitehouse > CC: cluster-devel@redhat.com > Signed-off-by: Jan Kara > --- > fs/gfs2/file.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > That looks ok to me... Acked-by: Steven Whitehouse Steve. > diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c > index c5fb359..1f03531 100644 > --- a/fs/gfs2/file.c > +++ b/fs/gfs2/file.c > @@ -375,6 +375,9 @@ static int gfs2_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) > */ > vfs_check_frozen(inode->i_sb, SB_FREEZE_WRITE); > > + /* Update file times before taking page lock */ > + file_update_time(vma->vm_file); > + > gfs2_holder_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh); > ret = gfs2_glock_nq(&gh); > if (ret)