linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Divy Le Ray <divy@chelsio.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: pull request: linux-firmware: update cxgb* firmwares
Date: Sun, 19 Feb 2012 00:58:24 +0000	[thread overview]
Message-ID: <1329613104.3258.44.camel@deadeye> (raw)
In-Reply-To: <4F3EAAE3.5070705@chelsio.com>

[-- Attachment #1: Type: text/plain, Size: 1944 bytes --]

On Fri, 2012-02-17 at 11:30 -0800, Divy Le Ray wrote:
> On 2/16/2012 7:41 PM, Ben Hutchings wrote:
> > On Wed, 2012-02-15 at 23:18 -0800, Divy Le Ray wrote:
> > [...]
> >> The following changes since commit 38118a598df73d5a9fd72bf04910e8298db82a46:
> >>
> >>     linux-firmware: brcm: add firmware for bcm43236 usb device
> >> (2012-02-11 19:20:10 +0000)
> >>
> >> are available in the git repository at:
> >>     git://git.chelsio.net/pub/git/linux-firmware for-upstream
> >>
> >> Divy Le Ray (3):
> >>         linux-firmware: rename t4fw.bin
> >>         linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
> >>         linux-firmware: update cxgb3 driver firmware to revision 7.12.0
> >>
> >>    WHENCE                  |    4 +++-
> >>    cxgb3/t3fw-7.12.0.bin   |  Bin 0 ->  31812 bytes
> >>    cxgb4/t4fw-1.3.10.0.bin |  Bin 0 ->  241664 bytes
> >>    cxgb4/t4fw-1.4.16.0.bin |  Bin 0 ->  298496 bytes
> >>    cxgb4/t4fw.bin          |  Bin 241664 ->  17 bytes
> >>    5 files changed, 3 insertions(+), 1 deletions(-)
> >>    create mode 100755 cxgb3/t3fw-7.12.0.bin
> >>    create mode 100644 cxgb4/t4fw-1.3.10.0.bin
> >>    create mode 100644 cxgb4/t4fw-1.4.16.0.bin
> >>    mode change 100644 =>  120000 cxgb4/t4fw.bin
> > Are there any versions of the cxgb4 driver that will specifically
> > request cxgb4/t4fw-1.3.10.0.bin?  If not, what's the point of keeping it
> > around after changing the cxgb4/t4fw.bin symlink?
> 
> Hi Ben,
> 
> I originally removed cxgb4/t4fw-1.3.10.0.bin when I posted the request 
> against David's tree.
> Subsequent review from Neil requested to keep it around at least for a 
> while (https://lkml.org/lkml/2012/2/11/61).
> Either way is fine to me.

No, Neil said you need to maintain cxgb4/t4fw.bin, but it's perfectly
fine for that to be a symlink.

Ben.

-- 
Ben Hutchings
Every program is either trivial or else contains at least one bug

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2012-02-19  0:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-11  3:07 pull request: linux-firmware: update cxgb* firmwares Divy Le Ray
2012-02-11 14:07 ` Neil Horman
2012-02-13  5:52   ` Divy Le Ray
2012-02-13 11:37     ` Neil Horman
2012-02-16  7:18     ` Divy Le Ray
2012-02-17  3:41       ` Ben Hutchings
2012-02-17 19:26         ` Neil Horman
2012-02-17 19:30         ` Divy Le Ray
2012-02-19  0:58           ` Ben Hutchings [this message]
2012-02-19  1:04             ` Ben Hutchings
2012-02-19  1:35               ` Divy Le Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329613104.3258.44.camel@deadeye \
    --to=ben@decadent.org.uk \
    --cc=divy@chelsio.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).