From: Steven Price <steven.price@arm.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
robh@kernel.org, tomeu.vizoso@collabora.com,
alyssa.rosenzweig@collabora.com
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 3/3] drm/panfrost: add Amlogic GPU integration quirks
Date: Thu, 17 Sep 2020 11:29:09 +0100 [thread overview]
Message-ID: <132c32b9-b68a-8da9-310e-c85fe17be83e@arm.com> (raw)
In-Reply-To: <20200916150147.25753-4-narmstrong@baylibre.com>
On 16/09/2020 16:01, Neil Armstrong wrote:
> This adds the required GPU quirks, including the quirk in the PWR registers at the GPU
> reset time and the IOMMU quirk for shareability issues observed on G52 in Amlogic G12B SoCs.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 7c8a87d164c3..6e5dedacb777 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -658,7 +658,18 @@ static const struct panfrost_compatible default_data = {
> .pm_domain_names = NULL,
> };
>
> +static const struct panfrost_compatible amlogic_data = {
> + .num_supplies = ARRAY_SIZE(default_supplies),
> + .supply_names = default_supplies,
> + .vendor_quirk = panfrost_gpu_amlogic_quirk,
> +};
> +
> static const struct of_device_id dt_match[] = {
> + /* Set first to probe before the generic compatibles */
> + { .compatible = "amlogic,meson-gxm-mali",
> + .data = &amlogic_data, },
> + { .compatible = "amlogic,meson-g12a-mali",
> + .data = &amlogic_data, },
> { .compatible = "arm,mali-t604", .data = &default_data, },
> { .compatible = "arm,mali-t624", .data = &default_data, },
> { .compatible = "arm,mali-t628", .data = &default_data, },
>
next prev parent reply other threads:[~2020-09-17 10:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 15:01 [PATCH v2 0/3] drm/panfrost: add Amlogic integration quirks Neil Armstrong
2020-09-16 15:01 ` [PATCH v2 1/3] drm/panfrost: add support for vendor quirk Neil Armstrong
2020-09-17 10:29 ` Steven Price
2020-09-16 15:01 ` [PATCH v2 2/3] drm/panfrost: add amlogic reset quirk callback Neil Armstrong
2020-09-17 10:29 ` Steven Price
2020-09-16 15:01 ` [PATCH v2 3/3] drm/panfrost: add Amlogic GPU integration quirks Neil Armstrong
2020-09-17 10:29 ` Steven Price [this message]
2020-09-16 17:05 ` [PATCH v2 0/3] drm/panfrost: add Amlogic " Alyssa Rosenzweig
2020-09-21 7:52 ` Neil Armstrong
2020-09-21 9:17 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=132c32b9-b68a-8da9-310e-c85fe17be83e@arm.com \
--to=steven.price@arm.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).