From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932282Ab2BXQEu (ORCPT ); Fri, 24 Feb 2012 11:04:50 -0500 Received: from wp188.webpack.hosteurope.de ([80.237.132.195]:53211 "EHLO wp188.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757656Ab2BXQBh (ORCPT ); Fri, 24 Feb 2012 11:01:37 -0500 From: Danny Kukawka To: "David S. Miller" Cc: Danny Kukawka , Jeff Kirsher , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/12] fddi/skfp: check given MAC address, if invalid return -EADDRNOTAVAIL Date: Fri, 24 Feb 2012 17:01:14 +0100 Message-Id: <1330099282-4588-5-git-send-email-danny.kukawka@bisect.de> X-Mailer: git-send-email 1.7.8.3 In-Reply-To: <1330099282-4588-1-git-send-email-danny.kukawka@bisect.de> References: <1330099282-4588-1-git-send-email-danny.kukawka@bisect.de> X-bounce-key: webpack.hosteurope.de;danny.kukawka@bisect.de;1330099297;6c6eeb88; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check if given address is valid in .ndo_set_mac_address, if invalid return -EADDRNOTAVAIL as eth_mac_addr() already does if is_valid_ether_addr() fails. Signed-off-by: Danny Kukawka --- drivers/net/fddi/skfp/skfddi.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/fddi/skfp/skfddi.c b/drivers/net/fddi/skfp/skfddi.c index 3d9a459..1092d94 100644 --- a/drivers/net/fddi/skfp/skfddi.c +++ b/drivers/net/fddi/skfp/skfddi.c @@ -81,6 +81,7 @@ static const char * const boot_msg = #include #include #include +#include #include #include #include @@ -926,6 +927,8 @@ static int skfp_ctl_set_mac_address(struct net_device *dev, void *addr) skfddi_priv *bp = &smc->os; unsigned long Flags; + if (!is_valid_ether_addr(p_sockaddr->sa_data)) + return -EADDRNOTAVAIL; memcpy(dev->dev_addr, p_sockaddr->sa_data, FDDI_K_ALEN); spin_lock_irqsave(&bp->DriverLock, Flags); -- 1.7.8.3