From: Steven Whitehouse <swhiteho@redhat.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: David Teigland <teigland@redhat.com>,
linux-kernel@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: GFS2: Pre-pull patch posting (merge window)
Date: Fri, 23 Mar 2012 20:09:18 +0000 [thread overview]
Message-ID: <1332533358.2576.66.camel@menhir> (raw)
In-Reply-To: <4F6CD7AD.9030306@xenotime.net>
Hi,
On Fri, 2012-03-23 at 13:06 -0700, Randy Dunlap wrote:
> On 03/23/2012 12:41 PM, David Teigland wrote:
>
> >
> >> on i386:
> >>
> >> ERROR: "sctp_do_peeloff" [fs/dlm/dlm.ko] undefined!
> >>
> >>
> >> GFS2_FS selects DLM (if GFS2_FS_LOCKING_DLM, which is enabled).
> >> GFS2_FS selects IP_SCTP if DLM_SCTP, which is not enabled and not
> >> used anywhere else in the kernel tree AFAICT.
> >> DLM just always selects IP_SCTP.
> >
> > Here's what we have now:
> >
> > config GFS2_FS
> > tristate "GFS2 file system support"
> > depends on (64BIT || LBDAF)
> > select DLM if GFS2_FS_LOCKING_DLM
> > select CONFIGFS_FS if GFS2_FS_LOCKING_DLM
> > select SYSFS if GFS2_FS_LOCKING_DLM
> > select IP_SCTP if DLM_SCTP
> > select FS_POSIX_ACL
> > select CRC32
> > select QUOTACTL
> >
> > menuconfig DLM
> > tristate "Distributed Lock Manager (DLM)"
> > depends on EXPERIMENTAL && INET
> > depends on SYSFS && CONFIGFS_FS && (IPV6 || IPV6=n)
> > select IP_SCTP
> >
> > Why does gfs2 Kconfig bother with SCTP at all? It seems that line should
> > just be removed. I'll also remove EXPERIMENTAL. I don't understand the
> > vagaries of Kconfig, so a dumb question, how could sctp_do_peeloff
> > possibly be undefined if we're selecting SCTP.
>
> What is selecting SCTP? DLM? so GFS2 selects DLM, but selects
> don't follow dependency chains. Also, the "select IP_SCTP if DLM_SCTP"
> in GFS2 is meaningless since there is no DLM_SCTP.
>
> I just verified that the (posted) failing config still fails with
> today's linux-next.
>
The DLM_SCTP is historical. There used to be such a thing, but that
config option went away, and there is now run time selection of the DLM
transport. So that the GFS2 Kconfig should have been updated, however
that appears not to be enough on its own to resolve the issue,
Steve.
next prev parent reply other threads:[~2012-03-23 20:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 10:25 GFS2: Pre-pull patch posting (merge window) Steven Whitehouse
2012-03-19 10:25 ` [PATCH 01/12] GFS2: glock statistics gathering Steven Whitehouse
2012-03-19 10:25 ` [PATCH 02/12] GFS2: Move two functions from log.c to lops.c Steven Whitehouse
2012-03-19 10:25 ` [PATCH 03/12] GFS2: FITRIM ioctl support Steven Whitehouse
2012-03-19 10:25 ` [PATCH 04/12] GFS2: Sort the ordered write list Steven Whitehouse
2012-03-19 10:25 ` [PATCH 05/12] GFS2: Make bd_cmp() static Steven Whitehouse
2012-03-19 10:25 ` [PATCH 06/12] GFS2: Unlock rindex mutex on glock error Steven Whitehouse
2012-03-19 10:25 ` [PATCH 07/12] GFS2: Eliminate sd_rindex_mutex Steven Whitehouse
2012-03-19 10:25 ` [PATCH 08/12] GFS2: make sure rgrps are up to date in func gfs2_blk2rgrpd Steven Whitehouse
2012-03-19 10:25 ` [PATCH 09/12] GFS2: Flush pending glock work when evicting an inode Steven Whitehouse
2012-03-19 10:25 ` [PATCH 10/12] GFS2: Remove a __GFP_NOFAIL allocation Steven Whitehouse
2012-03-19 10:25 ` [PATCH 11/12] GFS2: Clean up log flush header writing Steven Whitehouse
2012-03-19 10:25 ` [PATCH 12/12] GFS2: call gfs2_write_alloc_required for each chunk Steven Whitehouse
2012-03-19 14:45 ` GFS2: Pre-pull patch posting (merge window) Randy Dunlap
2012-03-19 14:59 ` Steven Whitehouse
2012-03-19 15:18 ` Randy Dunlap
2012-03-19 15:34 ` Steven Whitehouse
2012-03-23 19:41 ` David Teigland
2012-03-23 19:46 ` David Miller
2012-03-23 20:06 ` Randy Dunlap
2012-03-23 20:09 ` Steven Whitehouse [this message]
2012-03-23 20:18 ` David Teigland
2012-03-23 22:06 ` Benjamin Poirier
2012-03-23 22:48 ` Randy Dunlap
2012-03-26 10:44 ` Steven Whitehouse
2012-04-02 15:35 ` Randy Dunlap
2012-04-02 15:47 ` Steven Whitehouse
2012-03-23 22:06 ` Randy Dunlap
2012-03-20 9:47 ` Steven Whitehouse
-- strict thread matches above, loose matches on Subject: below --
2014-10-08 9:53 Steven Whitehouse
2014-06-03 11:02 Steven Whitehouse
2014-04-01 9:15 Steven Whitehouse
2014-01-20 12:23 Steven Whitehouse
2013-11-04 11:09 Steven Whitehouse
2013-09-05 9:02 GFS2 " Steven Whitehouse
2013-07-01 9:33 GFS2: " Steven Whitehouse
2013-04-26 9:18 Steven Whitehouse
2013-02-19 10:07 Steven Whitehouse
2012-11-30 9:52 Steven Whitehouse
2012-09-26 8:25 Steven Whitehouse
2012-07-23 8:00 Steven Whitehouse
2012-05-17 12:23 Steven Whitehouse
2012-01-05 11:51 Steven Whitehouse
2011-10-24 12:48 Steven Whitehouse
2011-07-22 9:16 Steven Whitehouse
2011-05-19 8:46 Steven Whitehouse
2011-03-15 9:11 Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332533358.2576.66.camel@menhir \
--to=swhiteho@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).