linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Cc: kernel@pengutronix.de, Matthew Garrett <mjg59@srcf.ucam.org>,
	Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
	platform-driver-x86@vger.kernel.org,
	ibm-acpi-devel@lists.sourceforge.net
Subject: [PATCH v2 14/15] drivers/x86: mark const init data with __initconst instead of __initdata
Date: Fri, 30 Mar 2012 22:05:04 +0200	[thread overview]
Message-ID: <1333137905-13809-14-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20120330200358.GV15647@pengutronix.de>

As long as there is no other non-const variable marked __initdata in the
same compilation unit it doesn't hurt. If there were one however
compilation would fail with

	error: $variablename causes a section type conflict

because a section containing const variables is marked read only and so
cannot contain non-const variables.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>
Cc: platform-driver-x86@vger.kernel.org
Cc: ibm-acpi-devel@lists.sourceforge.net
---
changes since (implict) v1:
 - drop wrong changes to drivers/platform/x86/thinkpad_acpi.c

 drivers/platform/x86/dell-laptop.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index a05fc9c..882bfa4 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -94,7 +94,7 @@ static struct rfkill *wifi_rfkill;
 static struct rfkill *bluetooth_rfkill;
 static struct rfkill *wwan_rfkill;
 
-static const struct dmi_system_id __initdata dell_device_table[] = {
+static const struct dmi_system_id dell_device_table[] __initconst = {
 	{
 		.ident = "Dell laptop",
 		.matches = {
-- 
1.7.9.5


  parent reply	other threads:[~2012-03-30 20:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120330200358.GV15647@pengutronix.de>
2012-03-30 20:04 ` [PATCH v2 01/15] pinctrl: mark const init data with __initconst instead of __initdata Uwe Kleine-König
2012-04-03 20:47   ` Linus Walleij
2012-03-30 20:04 ` [PATCH v2 02/15] ARM: " Uwe Kleine-König
2012-04-11 11:34   ` Sekhar Nori
2012-03-30 20:04 ` [PATCH v2 03/15] FRV: " Uwe Kleine-König
2012-03-30 20:04 ` [PATCH v2 04/15] net: " Uwe Kleine-König
2012-03-30 20:04 ` [PATCH v2 05/15] hwmon: " Uwe Kleine-König
2012-03-31  3:54   ` Guenter Roeck
2012-03-31 14:09     ` Uwe Kleine-König
2012-03-31 20:14       ` Guenter Roeck
2012-03-30 20:04 ` [PATCH v2 06/15] mfd: " Uwe Kleine-König
2012-04-16 10:30   ` Samuel Ortiz
2012-03-30 20:04 ` [PATCH v2 07/15] mips: " Uwe Kleine-König
2012-03-30 20:04 ` [PATCH v2 08/15] h8300: " Uwe Kleine-König
2012-03-30 20:04 ` [PATCH v2 09/15] ia64: " Uwe Kleine-König
2012-03-30 20:05 ` [PATCH v2 10/15] powerpc: " Uwe Kleine-König
2012-03-30 20:05 ` [PATCH v2 11/15] gpio/samsung: " Uwe Kleine-König
2012-03-30 20:05 ` [PATCH v2 12/15] ide: " Uwe Kleine-König
2012-03-30 20:05 ` [PATCH v2 13/15] media/video/s5p-tv: " Uwe Kleine-König
2012-03-30 20:05 ` Uwe Kleine-König [this message]
2012-03-30 20:05 ` [PATCH v2 15/15] kstrtox: " Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333137905-13809-14-git-send-email-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).