linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "wangliang (C)" <wangliang101@huawei.com>
To: "palmerdabbelt@google.com" <palmerdabbelt@google.com>,
	"mcgrof@kernel.org" <mcgrof@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Wangle (RTOS FAE)" <wangle6@huawei.com>,
	"Chenxin (RTOS)" <kepler.chenxin@huawei.com>,
	Nixiaoming <nixiaoming@huawei.com>,
	"Wangkefeng (OS Kernel Lab)" <wangkefeng.wang@huawei.com>
Subject: 答复: [PATCH] arm:mmap: fix physical address overflow when CONFIG_ARM_LPAE=y
Date: Tue, 20 Jul 2021 07:37:16 +0000	[thread overview]
Message-ID: <133369ed88a54e40a3ebbc667763f5b1@huawei.com> (raw)
In-Reply-To: <20210715123012.61215-1-wangliang101@huawei.com>

add arm list

-----邮件原件-----
发件人: wangliang (C) 
发送时间: 2021年7月15日 20:30
收件人: palmerdabbelt@google.com; mcgrof@kernel.org; linux-kernel@vger.kernel.org; gregkh@linuxfoundation.org; linux@armlinux.org.uk
抄送: stable@vger.kernel.org; wangliang (C) <wangliang101@huawei.com>; Wangle (RTOS FAE) <wangle6@huawei.com>; Chenxin (RTOS) <kepler.chenxin@huawei.com>; Nixiaoming <nixiaoming@huawei.com>
主题: [PATCH] arm:mmap: fix physical address overflow when CONFIG_ARM_LPAE=y

When the CONFIG_ARM_LPAE is enabled on arm32, the physical address may exceed 32 bits. In the devmem_is_allowed function, the physical address is obtained through displacement of the physical page number.Without explicit translation, the physical address may overflow and be truncated.
Use the PFN_PHYS macro to fix this bug.

This bug was initially introduced in v2.6.37 with commit:087aaffcdf9c91.
In v5.10, this code has been modified by commit:527701eda5f196.

Fixes: 527701eda5f196 ("lib: Add a generic version of devmem_is_allowed")
Fixes: 087aaffcdf9c91 ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
Cc: stable@vger.kernel.org # v2.6.37
Signed-off-by: Liang Wang <wangliang101@huawei.com>
---
 lib/devmem_is_allowed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/devmem_is_allowed.c b/lib/devmem_is_allowed.c index c0d67c541849..60be9e24bd57 100644
--- a/lib/devmem_is_allowed.c
+++ b/lib/devmem_is_allowed.c
@@ -19,7 +19,7 @@
  */
 int devmem_is_allowed(unsigned long pfn)  {
-	if (iomem_is_exclusive(pfn << PAGE_SHIFT))
+	if (iomem_is_exclusive(PFN_PHYS(pfn)))
 		return 0;
 	if (!page_is_ram(pfn))
 		return 1;
--
2.32.0


  reply	other threads:[~2021-07-20  7:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15 12:30 Liang Wang
2021-07-20  7:37 ` wangliang (C) [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-07-15 12:20 Liang Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=133369ed88a54e40a3ebbc667763f5b1@huawei.com \
    --to=wangliang101@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kepler.chenxin@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mcgrof@kernel.org \
    --cc=nixiaoming@huawei.com \
    --cc=palmerdabbelt@google.com \
    --cc=stable@vger.kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=wangle6@huawei.com \
    --subject='Re: 答复: [PATCH] arm:mmap: fix physical address overflow when CONFIG_ARM_LPAE=y' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox