From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] irqdomain: print a warning if domains contain IRQ 0
Date: Thu, 19 Apr 2012 08:23:12 +1000 [thread overview]
Message-ID: <1334787792.3143.19.camel@pasglop> (raw)
In-Reply-To: <1334756420-12019-1-git-send-email-linus.walleij@stericsson.com>
On Wed, 2012-04-18 at 15:40 +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> Some of the clients using IRQ domains from the ARM VIC
> (arch/arm/common/vic.c) don't know that their (hardware) IRQ 0
> is silently ignored by the IRQ core, they will just notice
> that they're not getting this IRQ anymore. So print a warning
> if a domain contains IRQ 0 (NO_IRQ) so we get some noise about
> it atleast.
I don't understand. HW IRQ 0 is not ignored and works perfectly
fine on "normal" remapped domains. Or is this specific to "legacy
domains" ? In this case pls make it clear in the subject :-)
Cheers,
Ben.
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> kernel/irq/irqdomain.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 0e0ba5f..1444454 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -136,8 +136,10 @@ struct irq_domain *irq_domain_add_legacy(struct device_node *of_node,
> int hwirq = first_hwirq + i;
>
> /* IRQ0 gets ignored */
> - if (!irq)
> + if (!irq) {
> + pr_warn("trying to register IRQ 0 (NO_IRQ) in an irq domain\n");
> continue;
> + }
>
> /* Legacy flags are left to default at this point,
> * one can then use irq_create_mapping() to
next prev parent reply other threads:[~2012-04-18 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 13:40 [PATCH] irqdomain: print a warning if domains contain IRQ 0 Linus Walleij
2012-04-18 22:23 ` Benjamin Herrenschmidt [this message]
2012-04-18 22:32 ` Linus Walleij
2012-04-19 18:29 ` Grant Likely
2012-04-20 6:38 ` Linus Walleij
2012-04-27 18:56 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334787792.3143.19.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).