From: Ian Kent <raven@themaw.net>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, mjt@tls.msk.ru,
linux-kernel@vger.kernel.org, autofs@vger.kernel.org,
thomas@m3y3r.de, stable@kernel.org
Subject: Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design error.
Date: Sat, 28 Apr 2012 09:56:24 +0800 [thread overview]
Message-ID: <1335578184.4141.9.camel@perseus.themaw.net> (raw)
In-Reply-To: <20120427.151433.1007849975903946491.davem@davemloft.net>
On Fri, 2012-04-27 at 15:14 -0400, David Miller wrote:
> From: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Fri, 27 Apr 2012 11:55:12 -0700
>
> > On Fri, Apr 27, 2012 at 11:42 AM, Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> >>
> >> There's no question that systemd is broken.
> >
> > Actually, I'll take that back.
> >
> > Yes, systemd has breakage. But it's actually automount that is the
> > truly broken piece of sh*t.
> >
> > I think that 'automount' is even more broken. The fact that the
> > automount maintainers knew about this, and added TOTALLY BROKEN code
> > to their automount source tree, over five years ago, because the
> > authors clearly did not understand what the f*ck they were doing,
> > that's the real problem.
>
> I respectfully disagree.
>
> It's ugly as shit, but it is the only one place where one can be
> absolutely sure that we are dealing with a pipe passing those v5
> things around.
>
> All these hacks we have been talking about, assuming the mount means
> the pipe is for passing structure so-and-so around, and now trying
> to find some other check such as one on current->comm...
>
> That's better?
>
> Only the application really knows. And I bet the person who wrote
> that automountd code you find so distasteful analyzed this and came
> to realize how difficult the kernel side would be to get right.
There's nothing I can say in my defense, Linus has made that very clear,
over and again.
When I realized the alignment mistake there were already shipping
binaries so I decided it was too late to change that.
And I see I got the analysis of the architectures alignment wrong, mmmm,
that's bad as well.
I guess I'll just be quiet now since anything I say is probably going to
be wrong.
Ian
next prev parent reply other threads:[~2012-04-28 1:56 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 13:34 [PATCH v2] Introduce a version6 of autofs interface, to fix design error Michael Tokarev
2012-04-26 13:44 ` Michael Tokarev
2012-04-27 0:37 ` Linus Torvalds
2012-04-27 9:45 ` Michael Tokarev
2012-04-27 15:47 ` Mark Lord
2012-04-27 20:37 ` H. Peter Anvin
2012-04-28 22:20 ` Mark Lord
2012-04-27 16:22 ` David Miller
2012-04-27 17:10 ` Michael Tokarev
2012-04-27 17:28 ` David Miller
2012-04-27 18:19 ` Linus Torvalds
2012-04-27 18:34 ` David Miller
2012-04-27 18:42 ` Linus Torvalds
2012-04-27 18:55 ` Linus Torvalds
2012-04-27 19:14 ` David Miller
2012-04-27 19:16 ` David Miller
2012-04-27 19:19 ` Linus Torvalds
2012-04-27 19:24 ` David Miller
2012-04-27 19:56 ` Linus Torvalds
2012-04-27 20:13 ` Stef Bon
2012-04-27 20:29 ` David Miller
2012-04-27 22:40 ` Linus Torvalds
2012-04-27 20:43 ` H. Peter Anvin
2012-04-27 22:42 ` Linus Torvalds
2012-04-27 22:56 ` H. Peter Anvin
2012-04-27 23:07 ` Linus Torvalds
2012-04-28 0:03 ` H. Peter Anvin
2012-04-28 0:17 ` Linus Torvalds
2012-04-27 22:42 ` Alan Cox
2012-04-27 22:49 ` Linus Torvalds
2012-04-27 23:27 ` Linus Torvalds
2012-04-28 16:10 ` Linus Torvalds
2012-04-29 6:37 ` Michael Tokarev
2012-04-29 7:19 ` Linus Torvalds
2012-04-29 7:45 ` Michael Tokarev
2012-04-29 18:29 ` Linus Torvalds
2012-04-29 19:09 ` Linus Torvalds
2012-04-29 19:53 ` Michael Tokarev
2012-04-29 20:53 ` Linus Torvalds
2012-04-30 8:41 ` Thomas Meyer
2012-04-28 1:56 ` Ian Kent [this message]
2012-04-27 19:08 ` David Miller
2012-04-27 20:45 ` H. Peter Anvin
2012-04-27 20:42 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335578184.4141.9.camel@perseus.themaw.net \
--to=raven@themaw.net \
--cc=autofs@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=stable@kernel.org \
--cc=thomas@m3y3r.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).