From: Joe Perches <joe@perches.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: drivers: Probable misuses of ||
Date: Fri, 04 May 2012 15:09:38 -0700 [thread overview]
Message-ID: <1336169378.11505.10.camel@joe2Laptop> (raw)
In-Reply-To: <20120504220241.GA6279@sirena.org.uk>
On Fri, 2012-05-04 at 23:02 +0100, Mark Brown wrote:
> On Fri, May 04, 2012 at 02:54:37PM -0700, Joe Perches wrote:
> > On Wed, 2012-04-04 at 16:00 -0700, Joe Perches wrote:
>
> > > drivers/media/dvb/dvb-usb/it913x.c: if (ret == 0 || ret != -EBUSY || ret != -ETIMEDOUT)
> > > drivers/media/dvb/dvb-usb/it913x.c: if (ret == 0 || ret != -EBUSY || ret != -ETIMEDOUT)
> > > drivers/media/rc/fintek-cir.c: if ((chip != 0x0408) || (chip != 0x0804))
>
> > It's been a month.
>
> > Do you maintainers not care
> > about these obvious defects?
>
> It'd probably help if you were to supply more analysis as to what the
> issues you think you're seeing are - in the cases quoted above
> (especially the last one) there's no obvious bug without further
> analysis.
Likely the || should be &&.
if (val != foo || test != bar)
is always true when foo != bar
next prev parent reply other threads:[~2012-05-04 22:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 23:00 drivers: Probable misuses of || Joe Perches
2012-05-04 21:54 ` Joe Perches
2012-05-04 22:02 ` Mark Brown
2012-05-04 22:09 ` Joe Perches [this message]
2012-05-04 22:13 ` Mark Brown
2012-05-05 16:00 ` Guenter Roeck
2012-05-07 8:36 ` Mark Brown
2012-05-07 16:20 ` Joe Perches
2012-05-07 16:34 ` Mark Brown
2012-05-04 22:56 ` Alan Cox
2012-05-04 23:13 ` Joe Perches
2012-05-04 22:45 ` richard -rw- weinberger
2012-05-07 10:45 ` Mauro Carvalho Chehab
2012-05-07 15:22 ` [PATCH] re: drivers: Probable misuses of || - it913x.c Malcolm Priestley
2012-05-07 11:04 ` drivers: Probable misuses of || Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336169378.11505.10.camel@joe2Laptop \
--to=joe@perches.com \
--cc=JBottomley@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).