linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zheng Liu <gnehzuil.liu@gmail.com>
To: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	linux-scsi@vger.kernel.org
Cc: Jeff Garzik <jeff@garzik.org>, Zheng Liu <wenqing.lz@taobao.com>
Subject: [RFC][PATCH] libata: enable SATA disk fua detection on default
Date: Tue,  8 May 2012 11:24:03 +0800	[thread overview]
Message-ID: <1336447443-4685-1-git-send-email-wenqing.lz@taobao.com> (raw)

From: Zheng Liu <wenqing.lz@taobao.com>

Currently, SATA disk fua detection is disabled on default because most of
devices don't support this feature at that time.  With the development of
technology, more and more SATA disks support this feature.  So now we can enable
this detection on default.

Although fua detection is defined as a kernel module parameter, it is too hard
to set its value because it must be loaded and set before system starts up.
That needs to modify initrd file.  So it is inconvenient for administrator who
needs to manage a huge number of servers.

CC: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
---
 drivers/ata/libata-core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 23763a1..3627251 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -133,9 +133,9 @@ int atapi_passthru16 = 1;
 module_param(atapi_passthru16, int, 0444);
 MODULE_PARM_DESC(atapi_passthru16, "Enable ATA_16 passthru for ATAPI devices (0=off, 1=on [default])");
 
-int libata_fua = 0;
+int libata_fua = 1;
 module_param_named(fua, libata_fua, int, 0444);
-MODULE_PARM_DESC(fua, "FUA support (0=off [default], 1=on)");
+MODULE_PARM_DESC(fua, "FUA support (0=off, 1=on [default])");
 
 static int ata_ignore_hpa;
 module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644);
-- 
1.7.4.1


             reply	other threads:[~2012-05-08  3:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08  3:24 Zheng Liu [this message]
2012-05-09  5:38 ` [RFC][PATCH] libata: enable SATA disk fua detection on default Robert Hancock
2012-05-09  6:19   ` Zheng Liu
2012-05-09  8:25     ` Christoph Hellwig
2012-05-09  9:30       ` Zheng Liu
2012-05-09 11:12         ` Christoph Hellwig
2012-05-09 12:48           ` Zheng Liu
2012-05-09 13:20             ` Bernd Schubert
2012-05-09 13:23             ` Christoph Hellwig
2012-07-03  9:04 ` Zheng Liu
2012-07-03 20:11   ` Michael Tokarev
2012-07-04  2:47     ` Zheng Liu
2012-07-04  6:36       ` Michael Tokarev
2012-07-04  7:06         ` Zheng Liu
2012-09-09 20:34           ` Arvydas Sidorenko
2012-09-09 20:39             ` Jeff Garzik
2012-08-17 18:06 ` Enabling FUA for SATA drives (was Re: [RFC][PATCH] libata: enable SATA disk fua detection on default) Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336447443-4685-1-git-send-email-wenqing.lz@taobao.com \
    --to=gnehzuil.liu@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=wenqing.lz@taobao.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).