From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B18C4727D for ; Tue, 22 Sep 2020 10:34:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE4CE239A1 for ; Tue, 22 Sep 2020 10:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726577AbgIVKeX (ORCPT ); Tue, 22 Sep 2020 06:34:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:57986 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbgIVKeV (ORCPT ); Tue, 22 Sep 2020 06:34:21 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F3053B521; Tue, 22 Sep 2020 10:34:55 +0000 (UTC) Message-ID: <133be287646ff03e251b0a590b240fef650a0c19.camel@suse.de> Subject: Re: [PATCH 06/42] mfd: bcm2835: use PLATFORM_DEVID_NONE From: Nicolas Saenz Julienne To: Krzysztof Kozlowski , Lee Jones , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Chen-Yu Tsai , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Support Opensource , Andy Shevchenko , Milo Kim , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Sangbeom Kim , Tony Lindgren , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org Date: Tue, 22 Sep 2020 12:34:16 +0200 In-Reply-To: <20200921205016.20461-6-krzk@kernel.org> References: <20200921205016.20461-1-krzk@kernel.org> <20200921205016.20461-6-krzk@kernel.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-SqufxWVnSrUXf1qA/5ZH" User-Agent: Evolution 3.36.5 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-SqufxWVnSrUXf1qA/5ZH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2020-09-21 at 22:49 +0200, Krzysztof Kozlowski wrote: > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. >=20 > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Nicolas Saenz Julienne > drivers/mfd/bcm2835-pm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c > index 42fe67f1538e..a76014512bde 100644 > --- a/drivers/mfd/bcm2835-pm.c > +++ b/drivers/mfd/bcm2835-pm.c > @@ -44,7 +44,7 @@ static int bcm2835_pm_probe(struct platform_device *pde= v) > if (IS_ERR(pm->base)) > return PTR_ERR(pm->base); > =20 > - ret =3D devm_mfd_add_devices(dev, -1, > + ret =3D devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, > bcm2835_pm_devs, ARRAY_SIZE(bcm2835_pm_devs), > NULL, 0, NULL); > if (ret) > @@ -60,7 +60,7 @@ static int bcm2835_pm_probe(struct platform_device *pde= v) > if (IS_ERR(pm->asb)) > return PTR_ERR(pm->asb); > =20 > - ret =3D devm_mfd_add_devices(dev, -1, > + ret =3D devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, > bcm2835_power_devs, > ARRAY_SIZE(bcm2835_power_devs), > NULL, 0, NULL); --=-SqufxWVnSrUXf1qA/5ZH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl9p0ygACgkQlfZmHno8 x/5DhQf9E6d1y9M4iAU4g+kbh+bA1ey9/1H7PYxSbABFrrdX+TFHGZpRy9JA7aPz uSuPs8/ujIU1wMmhzXCdZmSzuWECMu+8TEM6NWjgJnFFbuSZfJJLYueXAjPZAuaR V06SZO5NkKZ9dCbrmcYd8JUyWZEsA5OIcFnPudyDB8GhbyAwI1tAWKcXB8POZNVt ro5s/GtMnV7OXwv677e/rx2FR4cEA8ZVBfMxZRIVsn1HZm9QOo2vczXllJi5D/9Z 7cRAmHYUSgnqoZtek8wfNolzTbUXyzastcB9WhDzwkr/2u5KbiNV+nCCONbIJmvX BC+7RCfUvMJrgM7X1/bB88EzCAgQfQ== =Rb3s -----END PGP SIGNATURE----- --=-SqufxWVnSrUXf1qA/5ZH--