From: Steven Rostedt <rostedt@goodmis.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kay Sievers <kay@vrfy.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Wu Fengguang <fengguang.wu@intel.com>,
Joe Perches <joe@perches.com>,
"Paul E. McKenney" <paulmck@us.ibm.com>
Subject: Re: [PATCH v3] printk: Have printk() never buffer its data
Date: Fri, 29 Jun 2012 07:18:38 -0400 [thread overview]
Message-ID: <1340968718.16702.98.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20120629053027.GA9841@kroah.com>
On Fri, 2012-06-29 at 01:30 -0400, Greg Kroah-Hartman wrote:
>
> > I wonder if it would be better to do the following for the above two
> > ifs:
> >
> > if (cont.len && cont.owner == current) {
> > if (!prefix)
> > stored = cont_add(facility, level, text, text_len);
> > cont_flush();
> > }
> >
> > If the prefix was true, then the cont.flush would be set when cont_add()
> > is called, and the first thing that cont_add() does:
> >
> > if (cont.len && cont.flushed)
> > return false;
> >
> > which would always be true (returning false) if prefix was set.
> >
> > And the second cont_flush() is a nop due to it doing:
> >
> > if (cont.flushed)
> > return;
>
> It might be "better", and this would be a nice optimization, but is it
> needed right now? In other words, I'd like to get this patch into
> linux-next soon to get testing to get to Linus before 3.5-final comes
> out, don't you?
Sure, pull it as is, and you can add my Tested-by, and Acked-by tags
(Steven Rostedt <rostedt@goodmis.org>).
I'll send you a patch to do this update that you can queue for 3.6.
OK?
-- Steve
next prev parent reply other threads:[~2012-06-29 11:18 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 19:05 [PATCH v3] printk: Have printk() never buffer its data Steven Rostedt
2012-06-25 22:07 ` Andrew Morton
2012-06-25 23:55 ` Greg Kroah-Hartman
2012-06-26 0:01 ` Linus Torvalds
2012-06-26 0:23 ` Greg Kroah-Hartman
2012-06-26 0:40 ` Linus Torvalds
2012-06-26 0:56 ` Kay Sievers
2012-06-26 1:40 ` Linus Torvalds
2012-06-26 16:07 ` Kay Sievers
2012-06-26 16:30 ` Joe Perches
2012-06-26 16:58 ` Greg Kroah-Hartman
2012-06-26 17:00 ` Kay Sievers
2012-06-26 17:02 ` Greg Kroah-Hartman
2012-06-26 18:34 ` Greg Kroah-Hartman
2012-06-26 18:38 ` Greg Kroah-Hartman
2012-06-26 18:48 ` Greg Kroah-Hartman
2012-06-27 15:13 ` Steven Rostedt
2012-06-27 15:18 ` Steven Rostedt
2012-06-27 15:26 ` Kay Sievers
2012-06-28 7:38 ` Kay Sievers
2012-06-28 1:48 ` Greg Kroah-Hartman
2012-06-28 1:54 ` Steven Rostedt
2012-06-28 2:55 ` Steven Rostedt
2012-06-29 5:30 ` Greg Kroah-Hartman
2012-06-29 11:18 ` Steven Rostedt [this message]
2012-06-29 15:40 ` Greg Kroah-Hartman
2012-06-28 5:00 ` Joe Perches
2012-07-05 7:03 ` Michael Neuling
2012-07-05 8:39 ` Kay Sievers
2012-07-05 8:53 ` Kay Sievers
2012-07-05 10:20 ` Michael Neuling
2012-07-05 11:47 ` Kay Sievers
2012-07-05 12:50 ` Kay Sievers
2012-07-06 0:41 ` Michael Neuling
2012-07-06 0:56 ` Kay Sievers
2012-07-06 3:39 ` Michael Neuling
2012-07-06 3:47 ` Michael Neuling
2012-07-06 10:46 ` Kay Sievers
2012-07-06 15:12 ` Kay Sievers
2012-07-06 21:04 ` Michael Neuling
2012-07-08 17:55 ` Kay Sievers
2012-07-09 17:09 ` Greg Kroah-Hartman
2012-07-09 17:15 ` Joe Perches
2012-07-09 22:36 ` Michael Neuling
2012-07-09 21:42 ` Joe Perches
2012-07-09 22:10 ` Kay Sievers
2012-07-09 22:29 ` Joe Perches
2012-07-09 22:40 ` Kay Sievers
2012-07-09 23:32 ` Joe Perches
2012-07-09 23:41 ` Joe Perches
2012-06-26 0:18 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340968718.16702.98.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@us.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).