From: Steven Rostedt <rostedt@goodmis.org>
To: Alexander van Heukelum <heukelum@fastmail.fm>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 5/6] ftrace/x86: Add separate function to save regs
Date: Thu, 05 Jul 2012 16:37:20 -0400 [thread overview]
Message-ID: <1341520640.21574.19.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1341334466.32545.140661097365717.3B7276E0@webmail.messagingengine.com>
On Tue, 2012-07-03 at 18:54 +0200, Alexander van Heukelum wrote:
> On Mon, Jul 2, 2012, at 16:03, Steven Rostedt wrote:
> > Email had 1 attachment:
> > + 0005-ftrace-x86-Add-separate-function-to-save-regs.patch
> > 23k (text/plain)
>
> Hi Steven,
>
> One thing that caught my eye...
>
> > diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
> > index e3e17a0..acd4963 100644
> > --- a/arch/x86/kernel/entry_32.S
> > +++ b/arch/x86/kernel/entry_32.S
> > @@ -1109,6 +1109,7 @@ ENTRY(ftrace_caller)
> > pushl %eax
> > pushl %ecx
> > pushl %edx
> > + pushl $0 /* Pass NULL as regs pointer */
> > movl 0xc(%esp), %eax
>
> This should now be changed to "0x10(%esp)", right?
Yeah, I think you're right. Actually, I think I originally had it as:
movl 0xc(%esp), %eax
+ pushl $0
But after a few other changes, it went to this. I haven't finished
testing against x86_64, and haven't started the i386 tests. I'm sure
this would have blown up then ;-)
Thanks,
-- Steve
>
> Greetings,
> Alexander
>
> > movl 0x4(%ebp), %edx
> > leal function_trace_op, %ecx
> > @@ -1118,6 +1119,7 @@ ENTRY(ftrace_caller)
> > ftrace_call:
> > call ftrace_stub
> >
> > + addl $4,%esp /* skip NULL pointer */
> > popl %edx
> > popl %ecx
> > popl %eax
next prev parent reply other threads:[~2012-07-05 20:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 20:03 [PATCH 0/6] [RFC v3] ftrace/kprobes: Setting up ftrace for kprobes Steven Rostedt
2012-07-02 20:03 ` [PATCH 1/6] ftrace: Pass ftrace_ops as third parameter to function trace callback Steven Rostedt
2012-07-02 20:03 ` [PATCH 2/6] ftrace: Consolidate arch dependent functions with list function Steven Rostedt
2012-07-02 20:03 ` [PATCH 3/6] ftrace: Return pt_regs to function trace callback Steven Rostedt
2012-07-03 5:19 ` Masami Hiramatsu
2012-07-11 15:28 ` Steven Rostedt
2012-08-21 15:00 ` [tip:perf/core] " tip-bot for Steven Rostedt
2012-07-02 20:03 ` [PATCH 4/6] ftrace/x86_32: Push ftrace_ops in as 3rd parameter to function tracer Steven Rostedt
2012-07-02 20:03 ` [PATCH 5/6] ftrace/x86: Add separate function to save regs Steven Rostedt
2012-07-03 8:29 ` Masami Hiramatsu
2012-07-11 16:22 ` Steven Rostedt
2012-07-11 16:28 ` Steven Rostedt
2012-07-12 2:08 ` Masami Hiramatsu
2012-07-03 16:54 ` Alexander van Heukelum
2012-07-05 20:37 ` Steven Rostedt [this message]
2012-07-02 20:03 ` [PATCH 6/6] ftrace/x86: Add save_regs for i386 function calls Steven Rostedt
2012-07-03 5:27 ` Masami Hiramatsu
2012-07-03 11:56 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341520640.21574.19.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).