From: Richard Weinberger <richard@nod.at>
To: linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, adrian.hunter@intel.com,
Heinz.Egger@linutronix.de, thomas.wucher@linutronix.de,
shmulik.ladkani@gmail.com, tglx@linutronix.de,
tim.bird@am.sony.com, Marius.Mazarel@ugal.ro,
artem.bityutskiy@linux.intel.com, nyoushchenko@mvista.com,
Richard Weinberger <richard@nod.at>
Subject: [PATCH 6/7] UBI: Fastmap: Make sure that find_wl_entry() never returns NULL
Date: Mon, 9 Jul 2012 14:18:42 +0200 [thread overview]
Message-ID: <1341836323-43916-7-git-send-email-richard@nod.at> (raw)
In-Reply-To: <1341836323-43916-1-git-send-email-richard@nod.at>
If the rbtree contains only one entry and we don't have fastmap
on flash find_wl_entry() might return NULL.
This must not happen.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/wl.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
index 79e3257..d61672d 100644
--- a/drivers/mtd/ubi/wl.c
+++ b/drivers/mtd/ubi/wl.c
@@ -376,7 +376,8 @@ static struct ubi_wl_entry *find_wl_entry(struct ubi_device *ubi,
/* If no fastmap has been written and this WL entry can be used
* as anchor PEB, hold it back and return the second best WL entry
* such that fastmap can use the anchor PEB later. */
- if (!ubi->fm_disabled && !ubi->fm && e->pnum < UBI_FM_MAX_START)
+ if (prev_e && !ubi->fm_disabled &&
+ !ubi->fm && e->pnum < UBI_FM_MAX_START)
return prev_e;
return e;
--
1.7.6.5
next prev parent reply other threads:[~2012-07-09 12:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 12:18 UBI fastmap updates Richard Weinberger
2012-07-09 12:18 ` [PATCH 1/7] UBI: Fastmap: Fix lock imbalance in case of an error Richard Weinberger
2012-07-09 12:18 ` [PATCH 2/7] UBI: Fastmap: Get rid of find_fastmap switch Richard Weinberger
2012-07-09 12:18 ` [PATCH 3/7] UBI: Fastmap: Fix memory leak in error path Richard Weinberger
2012-07-09 12:18 ` [PATCH 4/7] UBI: Fastmap: Fix double free " Richard Weinberger
2012-07-09 12:18 ` [PATCH 5/7] UBI: Fastmap: Kerneldoc fixes Richard Weinberger
2012-07-09 12:18 ` Richard Weinberger [this message]
2012-07-09 12:18 ` [PATCH 7/7] UBI: Fastmap: Make checkpatch.pl happy Richard Weinberger
2012-08-02 14:12 ` UBI fastmap updates Artem Bityutskiy
2012-08-02 14:15 ` Richard Weinberger
2012-08-02 14:29 ` Artem Bityutskiy
2012-08-02 14:51 ` Richard Weinberger
2012-08-02 16:17 ` Artem Bityutskiy
2012-08-02 16:32 ` Richard Weinberger
2012-08-02 16:45 ` Artem Bityutskiy
2012-08-02 16:54 ` Richard Weinberger
2012-08-02 17:03 ` Tim Bird
2012-08-02 17:06 ` Richard Weinberger
2012-08-02 17:40 ` Artem Bityutskiy
2012-08-02 17:45 ` Richard Weinberger
2012-08-02 17:59 ` Artem Bityutskiy
2012-08-02 18:03 ` Richard Weinberger
2012-08-02 18:15 ` Artem Bityutskiy
2012-08-05 8:23 ` Shmulik Ladkani
2012-08-05 14:25 ` Richard Weinberger
2012-08-02 17:50 ` Artem Bityutskiy
2012-08-02 14:58 ` Artem Bityutskiy
2012-08-02 14:59 ` Richard Weinberger
2012-08-02 15:18 ` Artem Bityutskiy
2012-08-02 15:19 ` Richard Weinberger
2012-08-06 17:36 ` Richard Weinberger
2012-08-07 4:21 ` Artem Bityutskiy
2012-08-07 7:29 ` Richard Weinberger
2012-08-07 18:53 ` Artem Bityutskiy
2012-08-02 18:50 ` Artem Bityutskiy
2012-08-02 18:56 ` Artem Bityutskiy
2012-08-03 8:47 ` Artem Bityutskiy
2012-08-03 8:56 ` Richard Weinberger
2012-08-17 13:11 ` Artem Bityutskiy
2012-08-17 13:33 ` Richard Weinberger
2012-08-17 13:41 ` Artem Bityutskiy
2012-08-17 13:43 ` Richard Weinberger
2012-08-17 14:06 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341836323-43916-7-git-send-email-richard@nod.at \
--to=richard@nod.at \
--cc=Heinz.Egger@linutronix.de \
--cc=Marius.Mazarel@ugal.ro \
--cc=adrian.hunter@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nyoushchenko@mvista.com \
--cc=shmulik.ladkani@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.wucher@linutronix.de \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).