From: Roland Stigge <stigge@antcom.de>
To: vitalywool@gmail.com, khali@linux-fr.org, ben-linux@fluff.org,
w.sang@pengutronix.de, grant.likely@secretlab.ca,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
kevin.wells@nxp.com, srinivas.bakki@nxp.com,
aletes.xgr@gmail.com, jonsmirl@gmail.com
Cc: Roland Stigge <stigge@antcom.de>
Subject: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
Date: Wed, 8 Aug 2012 09:42:31 +0200 [thread overview]
Message-ID: <1344411752-23469-1-git-send-email-stigge@antcom.de> (raw)
The I2C Control Register bits RFDAIE and RFFIE were mixed up. In addition to
this fix, this patch adds the missing bit DRSIE for completeness.
Signed-off-by: Roland Stigge <stigge@antcom.de>
---
Applies to v3.6-rc1
This patch for i2c-pnx affects PNX4008 and LPC32xx (and LPC31xx, not yet in
mainline). Can you please test and double-check the manuals of PNX4008 and
LPC31xx? I only found this via the manual of LPC32xx but assume it's the same
for the others, also.
Thanks in advance!
drivers/i2c/busses/i2c-pnx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.orig/drivers/i2c/busses/i2c-pnx.c
+++ linux-2.6/drivers/i2c/busses/i2c-pnx.c
@@ -48,8 +48,9 @@ enum {
mcntrl_afie = 0x00000002,
mcntrl_naie = 0x00000004,
mcntrl_drmie = 0x00000008,
- mcntrl_daie = 0x00000020,
- mcntrl_rffie = 0x00000040,
+ mcntrl_drsie = 0x00000010,
+ mcntrl_rffie = 0x00000020,
+ mcntrl_daie = 0x00000040,
mcntrl_tffie = 0x00000080,
mcntrl_reset = 0x00000100,
mcntrl_cdbmode = 0x00000400,
next reply other threads:[~2012-08-08 7:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 7:42 Roland Stigge [this message]
2012-08-08 7:42 ` [PATCH RESEND 2/2] i2c: pnx: Fix read transactions of >= 2 bytes Roland Stigge
2012-08-18 9:52 ` Wolfram Sang
2012-08-19 8:45 ` Roland Stigge
2012-08-18 9:51 ` [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions Wolfram Sang
2012-08-19 8:47 ` Roland Stigge
2012-08-20 16:26 ` Kevin Wells
2012-08-20 16:47 ` Roland Stigge
2012-08-20 19:49 ` Arnd Bergmann
2012-08-20 17:55 ` Wolfram Sang
2012-08-20 20:47 ` Roland Stigge
2012-09-03 20:16 ` Roland Stigge
2012-09-04 9:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344411752-23469-1-git-send-email-stigge@antcom.de \
--to=stigge@antcom.de \
--cc=aletes.xgr@gmail.com \
--cc=ben-linux@fluff.org \
--cc=grant.likely@secretlab.ca \
--cc=jonsmirl@gmail.com \
--cc=kevin.wells@nxp.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.bakki@nxp.com \
--cc=vitalywool@gmail.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).