From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@amd64.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [RFC PATCH -v2 3/4] perf: Add persistent event facilities
Date: Thu, 16 Aug 2012 18:12:35 -0400 [thread overview]
Message-ID: <1345155155.3708.19.camel@gandalf.local.home> (raw)
In-Reply-To: <1345139123-15212-4-git-send-email-bp@amd64.org>
On Thu, 2012-08-16 at 19:45 +0200, Borislav Petkov wrote:
>
> -static void ring_buffer_put(struct ring_buffer *rb)
> +void ring_buffer_put(struct ring_buffer *rb)
> {
> struct perf_event *event, *n;
> unsigned long flags;
I have to say that it is really unfortunate that we have two ring
buffers in the kernel, called struct ring_buffer. One being global and
one being local to events. And now we are exporting the name
"ring_buffer_*" too! This is going to confuse the hell out of people.
Perhaps this should have been called perf_buffer, as that is what it's
used for.
-- Steve
next prev parent reply other threads:[~2012-08-16 22:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 17:45 [RFC PATCH -v2 0/4] Persistent events Borislav Petkov
2012-08-16 17:45 ` [RFC PATCH -v2 1/4] trace events: Interface to add files to debugfs Borislav Petkov
2012-08-16 22:06 ` Steven Rostedt
2012-08-17 7:26 ` Borislav Petkov
2012-08-16 17:45 ` [RFC PATCH -v2 2/4] perf: Add persistent events Borislav Petkov
2012-08-16 17:45 ` [RFC PATCH -v2 3/4] perf: Add persistent event facilities Borislav Petkov
2012-08-16 22:12 ` Steven Rostedt [this message]
2012-08-17 7:27 ` Borislav Petkov
2012-12-09 12:06 ` Borislav Petkov
2012-08-21 10:08 ` Peter Zijlstra
2012-08-21 10:21 ` Peter Zijlstra
2012-08-16 17:45 ` [RFC PATCH -v2 4/4] persistent test Borislav Petkov
2012-08-16 20:12 ` [RFC PATCH -v2 0/4] Persistent events Jonathan Corbet
2012-08-16 20:55 ` Borislav Petkov
2012-08-16 21:13 ` Steven Rostedt
2012-08-16 21:41 ` Borislav Petkov
2012-08-16 22:00 ` Steven Rostedt
2012-08-17 7:38 ` Borislav Petkov
2012-08-17 15:20 ` Steven Rostedt
2012-08-17 17:06 ` Peter Zijlstra
2012-08-21 10:30 ` Peter Zijlstra
2012-08-21 13:11 ` Borislav Petkov
2012-08-21 13:41 ` Steven Rostedt
2012-08-21 13:50 ` Borislav Petkov
2012-08-21 14:03 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345155155.3708.19.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=borislav.petkov@amd.com \
--cc=bp@amd64.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).