From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Rik van Riel <riel@redhat.com>, Minchan Kim <minchan@kernel.org>,
Jim Schutt <jaschut@sandia.gov>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mgorman@suse.de>
Subject: [PATCH 5/7] mm: compaction: Update comment in try_to_compact_pages
Date: Fri, 17 Aug 2012 15:14:31 +0100 [thread overview]
Message-ID: <1345212873-22447-6-git-send-email-mgorman@suse.de> (raw)
In-Reply-To: <1345212873-22447-1-git-send-email-mgorman@suse.de>
The comment about order applied when the check was
order > PAGE_ALLOC_COSTLY_ORDER which has not been the case since
[c5a73c3d: thp: use compaction for all allocation orders]. Fixing
the comment while I'm in the general area.
Signed-off-by: Mel Gorman <mgorman@suse.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
Reviewed-by: Minchan Kim <minchan@kernel.org>
---
mm/compaction.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 6bf7f86..1c51395 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -871,11 +871,7 @@ unsigned long try_to_compact_pages(struct zonelist *zonelist,
struct zone *zone;
int rc = COMPACT_SKIPPED;
- /*
- * Check whether it is worth even starting compaction. The order check is
- * made because an assumption is made that the page allocator can satisfy
- * the "cheaper" orders without taking special steps
- */
+ /* Check if the GFP flags allow compaction */
if (!order || !may_enter_fs || !may_perform_io)
return rc;
--
1.7.9.2
next prev parent reply other threads:[~2012-08-17 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 14:14 [PATCH 0/7] Improve hugepage allocation success rates under load V5 Mel Gorman
2012-08-17 14:14 ` [PATCH 1/7] Revert __GFP_NO_KSWAPD removal Mel Gorman
2012-08-17 14:14 ` [PATCH 2/7] mm: have order > 0 compaction start near a pageblock with free pages Mel Gorman
2012-08-17 14:14 ` [PATCH 3/7] mm: compaction: Abort async compaction if locks are contended or taking too long Mel Gorman
2012-08-17 14:14 ` [PATCH 4/7] mm: remove __GFP_NO_KSWAPD Mel Gorman
2012-08-17 14:14 ` Mel Gorman [this message]
2012-08-17 14:14 ` [PATCH 6/7] mm: vmscan: Scale number of pages reclaimed by reclaim/compaction based on failures Mel Gorman
2012-09-06 22:36 ` Andrew Morton
2012-08-17 14:14 ` [PATCH 7/7] mm: compaction: Capture a suitable high-order page immediately when it is made available Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345212873-22447-6-git-send-email-mgorman@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jaschut@sandia.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).