From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: kernel-janitors@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH 9/14] drivers/spi/spi-omap-100k.c: fix error return code
Date: Sun, 19 Aug 2012 10:44:28 +0200 [thread overview]
Message-ID: <1345365870-29831-13-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1345365870-29831-1-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Initialize return variable before exiting on an error path.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Actually, omap1_spi100k_reset currently always returns 0, so the test is
never true. Perhaps this should be taken into account in some other way.
drivers/spi/spi-omap-100k.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c
index 9bd1c92..b581107 100644
--- a/drivers/spi/spi-omap-100k.c
+++ b/drivers/spi/spi-omap-100k.c
@@ -542,7 +542,8 @@ static int __devinit omap1_spi100k_probe(struct platform_device *pdev)
goto err2;
}
- if (omap1_spi100k_reset(spi100k) < 0)
+ status = omap1_spi100k_reset(spi100k);
+ if (status < 0)
goto err3;
status = spi_register_master(master);
next prev parent reply other threads:[~2012-08-19 8:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 8:44 [PATCH 0/14] fix error return code Julia Lawall
2012-08-19 8:44 ` [PATCH 1/14] drivers/rpmsg/virtio_rpmsg_bus.c: " Julia Lawall
2012-08-19 8:44 ` [PATCH 6/14] drivers/power/wm97xx_battery.c: " Julia Lawall
2012-08-19 8:44 ` [PATCH 5/14] drivers/power/ab8500_charger.c: " Julia Lawall
2012-08-19 8:44 ` [PATCH 4/14] drivers/power/bq27x00_battery.c: " Julia Lawall
2012-08-19 8:44 ` [PATCH 3/14] drivers/power/ab8500_fg.c: " Julia Lawall
2012-08-19 8:44 ` [PATCH 2/14] drivers/power/ab8500_btemp.c: " Julia Lawall
2012-08-23 1:51 ` Anton Vorontsov
2012-08-19 8:44 ` [PATCH 7/14] drivers/mtd/maps/rbtx4939-flash.c: delete unneeded test Julia Lawall
2012-08-25 11:04 ` Artem Bityutskiy
2012-08-19 8:44 ` [PATCH 8/14] drivers/video/sunxvr2500.c: fix error return code Julia Lawall
2012-08-23 20:48 ` Florian Tobias Schandinat
2012-08-19 8:44 ` [PATCH 12/14] drivers/spi/spi-coldfire-qspi.c: " Julia Lawall
2012-08-19 8:44 ` [PATCH 11/14] drivers/spi/spi-orion.c: " Julia Lawall
2012-08-19 8:44 ` [PATCH 10/14] drivers/spi/spi-ep93xx.c: " Julia Lawall
2012-08-22 16:12 ` H Hartley Sweeten
2012-08-19 8:44 ` Julia Lawall [this message]
2012-08-19 8:44 ` [PATCH 13/14] drivers/mtd/ubi/build.c: " Julia Lawall
2012-08-25 11:10 ` Artem Bityutskiy
2012-08-19 8:44 ` [PATCH 14/14] drivers/spi/spi-s3c24xx.c: " Julia Lawall
2012-08-22 9:38 ` Kukjin Kim
2012-08-22 11:40 ` Mark Brown
2012-08-22 11:42 ` Julia Lawall
2012-08-22 17:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345365870-29831-13-git-send-email-Julia.Lawall@lip6.fr \
--to=julia.lawall@lip6.fr \
--cc=grant.likely@secretlab.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).