From: "Jürgen Groß" <jgross@suse.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
stable@vger.kernel.org, Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 2/8] xen/events: don't unmask an event channel when an eoi is pending
Date: Sat, 6 Mar 2021 17:18:25 +0100 [thread overview]
Message-ID: <134540c1-40ac-3607-6ca0-3dcd5f83a013@suse.com> (raw)
In-Reply-To: <d368a948-17d6-4e64-110e-bede3158f49f@citrix.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1488 bytes --]
On 23.02.21 10:26, Ross Lagerwall wrote:
> On 2021-02-19 15:40, Juergen Gross wrote:
>> An event channel should be kept masked when an eoi is pending for it.
>> When being migrated to another cpu it might be unmasked, though.
>>
>> In order to avoid this keep three different flags for each event channel
>> to be able to distinguish "normal" masking/unmasking from eoi related
>> masking/unmasking and temporary masking. The event channel should only
>> be able to generate an interrupt if all flags are cleared.
>>
>> Cc: stable@vger.kernel.org
>> Fixes: 54c9de89895e0a36047 ("xen/events: add a new late EOI evtchn framework")
>> Reported-by: Julien Grall <julien@xen.org>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> I tested this patch series backported to a 4.19 kernel and found that
> when doing a reboot loop of Windows with PV drivers, occasionally it will
> end up in a state with some event channels pending and masked in dom0
> which breaks networking in the guest.
>
> The issue seems to have been introduced with this patch, though at first
> glance it appears correct. I haven't yet looked into why it is happening.
> Have you seen anything like this with this patch?
I have found the issue. lateeoi_mask_ack_dynirq() must not set the "eoi"
mask reason flag, as this callback will be called when the handler will
not be called later, so there will never be a call of xen_irq_lateeoi()
to unmask the event channel again.
Juergen
[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-03-06 16:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 15:40 [PATCH v3 0/8] xen/events: bug fixes and some diagnostic aids Juergen Gross
2021-02-19 15:40 ` [PATCH v3 1/8] xen/events: reset affinity of 2-level event when tearing it down Juergen Gross
2021-02-19 15:40 ` [PATCH v3 2/8] xen/events: don't unmask an event channel when an eoi is pending Juergen Gross
2021-02-20 12:10 ` Julien Grall
2021-02-23 9:26 ` Ross Lagerwall
2021-03-05 10:53 ` Jürgen Groß
2021-03-06 16:18 ` Jürgen Groß [this message]
2021-02-19 15:40 ` [PATCH v3 3/8] xen/events: avoid handling the same event on two cpus at the same time Juergen Gross
2021-02-20 12:12 ` Julien Grall
2021-02-19 15:40 ` [PATCH v3 4/8] xen/netback: fix spurious event detection for common event case Juergen Gross
2021-02-19 15:40 ` [PATCH v3 5/8] xen/events: link interdomain events to associated xenbus device Juergen Gross
2021-02-22 14:50 ` Roger Pau Monné
2021-02-19 15:40 ` [PATCH v3 6/8] xen/events: add per-xenbus device event statistics and settings Juergen Gross
2021-02-19 15:40 ` [PATCH v3 7/8] xen/evtchn: use smp barriers for user event ring Juergen Gross
2021-02-19 15:40 ` [PATCH v3 8/8] xen/evtchn: use READ/WRITE_ONCE() for accessing ring indices Juergen Gross
2021-02-20 20:35 ` Boris Ostrovsky
2021-02-23 15:44 ` [PATCH v3 0/8] xen/events: bug fixes and some diagnostic aids Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=134540c1-40ac-3607-6ca0-3dcd5f83a013@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=julien@xen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).