From: Tim Chen <tim.c.chen@linux.intel.com>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-mm@kvack.org, linux-kernel <linux-kernel@vger.kernel.org>,
Alex Shi <alex.shi@intel.com>
Subject: Re: [RFC PATCH 2/2] mm: Batch page_check_references in shrink_page_list sharing the same i_mmap_mutex
Date: Tue, 21 Aug 2012 10:51:02 -0700 [thread overview]
Message-ID: <1345571462.13492.249.camel@schen9-DESK> (raw)
In-Reply-To: <20120821132129.GC6960@linux.intel.com>
On Tue, 2012-08-21 at 09:21 -0400, Matthew Wilcox wrote:
> Is there a (performant) way to avoid passing around the
> 'mmap_mutex_locked' state?
>
> For example, does it hurt to have all the callers hold the i_mmap_mutex()
> over the entire call, or do we rely on being able to execute large chunks
> of this in parallel?
>
> Here's what I'm thinking:
>
> 1. Rename the existing page_referenced implementation to __page_referenced().
> 2. Add:
>
> int needs_page_mmap_mutex(struct page *page)
> {
> return page->mapping && page_mapped(page) && page_rmapping(page) &&
> !PageKsm(page) && !PageAnon(page);
> }
>
> int page_referenced(struct page *page, int is_locked, struct mem_cgroup *memcg,
> unsigned long *vm_flags)
> {
> int result, needs_lock;
>
> needs_lock = needs_page_mmap_mutex(page);
> if (needs_lock)
> mutex_lock(&page->mapping->i_mmap_mutex);
> result = __page_referenced(page, is_locked, memcg, vm_flags);
> if (needs_lock)
> mutex_unlock(&page->mapping->i_mmap_mutex);
> return result;
> }
>
> 3. Rename the existing try_to_unmap() to __try_to_unmap()
> 4. Add:
>
> int try_to_unmap(struct page *page, enum ttu_flags flags)
> {
> int result, needs_lock;
>
> needs_lock = needs_page_mmap_mutex(page);
> if (needs_lock)
> mutex_lock(&page->mapping->i_mmap_mutex);
> result = __try_to_unmap(page, is_locked, memcg, vm_flags);
> if (needs_lock)
> mutex_unlock(&page->mapping->i_mmap_mutex);
> return result;
> }
>
> 5. Change page_check_references to always call __page_referenced (since it
> now always holds the mutex)
> 6. Replace the mutex_lock() calls in page_referenced_file() and
> try_to_unmap_file() with
> BUG_ON(!mutex_is_locked(&mapping->i_mmap_mutex));
> 7. I think you can simplify this:
I like your proposal and will try to test with a new patch along your
suggestions. Though I will be out the rest of the week and may be
delayed a bit getting the testing completed.
Tim
next prev parent reply other threads:[~2012-08-21 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 1:06 [RFC PATCH 2/2] mm: Batch page_check_references in shrink_page_list sharing the same i_mmap_mutex Tim Chen
2012-08-20 16:43 ` Tim Chen
2012-08-21 13:21 ` Matthew Wilcox
2012-08-21 17:51 ` Tim Chen [this message]
2012-08-21 22:53 ` Tim Chen
2012-08-22 0:48 ` Tim Chen
2012-08-23 18:33 ` Matthew Wilcox
2012-09-04 15:21 ` Tim Chen
2012-09-04 22:54 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345571462.13492.249.camel@schen9-DESK \
--to=tim.c.chen@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan@kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).