From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/5] perf tools: Cleanup hist printing code (v4)
Date: Wed, 22 Aug 2012 14:48:32 +0900 [thread overview]
Message-ID: <1345614517-5753-1-git-send-email-namhyung@kernel.org> (raw)
Hi,
This is a cleanup and refactoring patchset for the hist printing code
by adding perf_hpp__format functions and perf_hpp. I believe it makes
the code easy to maintain and to add new features like upcoming group
viewing and callchain accumulation.
Any comments are welcome, thanks.
Namhyung
v3 -> v4:
* Rebase to current acme/perf/core
* The first two in the previous series have been merged
* Rename hist_period_print to perf_hpp_fmt (Arnaldo)
* Rename ctx->s to hpp->buf (Arnaldo)
v2 -> v3:
* Move fprintf code to ui/stdio/hist.c (Arnaldo)
* Add ack from Pekka
Namhyung Kim (5):
perf hists: Introduce perf_hpp for hist period printing
perf hists: Handle field separator properly
perf hists: Use perf_hpp__format->width to calculate the column widths
perf ui/browser: Use perf_hpp__format functions
perf gtk/browser: Use perf_hpp__format functions
tools/perf/Makefile | 2 +
tools/perf/builtin-diff.c | 1 +
tools/perf/ui/browsers/hists.c | 94 ++++++++---
tools/perf/ui/gtk/browser.c | 101 ++++++++++--
tools/perf/ui/gtk/gtk.h | 1 +
tools/perf/ui/gtk/setup.c | 1 +
tools/perf/ui/hist.c | 366 +++++++++++++++++++++++++++++++++++++++++
tools/perf/ui/setup.c | 8 +-
tools/perf/ui/stdio/hist.c | 239 +++++----------------------
tools/perf/ui/tui/setup.c | 4 +
tools/perf/util/hist.c | 33 ----
tools/perf/util/hist.h | 37 +++++
12 files changed, 616 insertions(+), 271 deletions(-)
create mode 100644 tools/perf/ui/hist.c
--
1.7.11.4
next reply other threads:[~2012-08-22 5:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 5:48 Namhyung Kim [this message]
2012-08-22 5:48 ` [PATCH 1/5] perf hists: Introduce perf_hpp for hist period printing Namhyung Kim
2012-08-22 5:48 ` [PATCH 2/5] perf hists: Handle field separator properly Namhyung Kim
2012-08-22 5:48 ` [PATCH 3/5] perf hists: Use perf_hpp__format->width to calculate the column widths Namhyung Kim
2012-08-22 5:48 ` [PATCH 4/5] perf ui/browser: Use perf_hpp__format functions Namhyung Kim
2012-08-22 5:48 ` [PATCH 5/5] perf gtk/browser: " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345614517-5753-1-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).