linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Zimmer <nzimmer@sgi.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	adobriyan@gmail.com, Nathan Zimmer <nzimmer@sgi.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH] fs/prof: Update comment on pde_unload_lock
Date: Wed, 22 Aug 2012 11:38:30 -0500	[thread overview]
Message-ID: <1345653510-22000-2-git-send-email-nzimmer@sgi.com> (raw)
In-Reply-To: <1345653510-22000-1-git-send-email-nzimmer@sgi.com>

The comment was updated to include the other structures held by the lock.

Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: David Woodhouse <dwmw2@infradead.org>
Acked-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Nathan Zimmer <nzimmer@sgi.com>
---
 include/linux/proc_fs.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h
index 3fd2e87..42e57e3 100644
--- a/include/linux/proc_fs.h
+++ b/include/linux/proc_fs.h
@@ -73,7 +73,8 @@ struct proc_dir_entry {
 	int pde_users;	/* number of callers into module in progress */
 	struct completion *pde_unload_completion;
 	struct list_head pde_openers;	/* who did ->open, but not ->release */
-	spinlock_t pde_unload_lock; /* proc_fops checks and pde_users bumps */
+	spinlock_t pde_unload_lock;	/* proc_fops checks, pde_users bumps */
+					/* pde_openers, pde_unload_completion */
 	u8 namelen;
 	char name[];
 };
-- 
1.6.0.2


  reply	other threads:[~2012-08-22 16:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 16:38 [PATCH] fs/proc: Move kfree outside pde_unload_lock Nathan Zimmer
2012-08-22 16:38 ` Nathan Zimmer [this message]
2012-08-22 18:28 ` Eric Dumazet
2012-08-22 21:42   ` Eric Dumazet
2012-08-23 17:54     ` Nathan Zimmer
2012-08-24 14:48     ` Nathan Zimmer
2012-08-24 14:58       ` Eric Dumazet
2012-08-24 16:45         ` Nathan Zimmer
2012-08-24 21:43           ` Nathan Zimmer
2012-08-28 20:38     ` Alexey Dobriyan
2012-08-29  4:11       ` Eric Dumazet
2012-08-29  8:32         ` Alexey Dobriyan
2012-08-29 13:50         ` Alexey Dobriyan
2012-08-29 14:24           ` Eric Dumazet
2012-09-17 15:57             ` Nathan Zimmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345653510-22000-2-git-send-email-nzimmer@sgi.com \
    --to=nzimmer@sgi.com \
    --cc=adobriyan@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).